Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.14] backport Assert EventTypes references for IMC test (#7899) #868

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[release-v1.14] backport Assert EventTypes references for IMC test (#7899) #868

merged 1 commit into from
Sep 17, 2024

Conversation

maschmid
Copy link

Backports knative#7899

  • Assert EventTypes references for IMC and ContainerSource test
  • Do not use ID as the attribute to match the event
    The id is different for each event when using container source. Use just the type, like other tests for container source.
  • Fix type
  • Remove test for ContainerSource EventType creation
    It is not supported.

@mgencur @maschmid
Assert EventTypes references for IMC test (knative#7899)
314a381 
* Assert EventTypes references for IMC and ContainerSource test

* Do not use ID as the attribute to match the event

The id is different for each event when using container source. Use just
the type, like other tests for container source.

* Fix type

* Remove test for ContainerSource EventType creation

It is not supported.
@openshift-ci openshift-ci bot requested review from aliok and lberk September 17, 2024 08:44
pierDipi
pierDipi approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Sep 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maschmid, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 607aceb and 2 for PR HEAD 314a381 in total

@pierDipi
Copy link
Member 


11:16:00.235 INFO:    Create an image build for serverless-openshift-knative-operator
error: provided Dockerfile is not valid: Syntax error - can't find = in "Knative". Must be of the form: name=value

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 17, 2024 •
edited
Loading

@maschmid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/413-test-encryption-auth-e2e-aws-413 314a381 link true /test 413-test-encryption-auth-e2e-aws-413
ci/prow/415-test-e2e-aws-415 314a381 link true /test 415-test-e2e-aws-415
ci/prow/415-test-conformance-aws-415 314a381 link true /test 415-test-conformance-aws-415

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 607aceb and 2 for PR HEAD 314a381 in total

@pierDipi pierDipi merged commit b4c2c90 into openshift-knative:release-v1.14 Sep 17, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@aliok aliok Awaiting requested review from aliok

@lberk lberk Awaiting requested review from lberk

Assignees

@pierDipi pierDipi

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maschmid @openshift-ci-robot @pierDipi @mgencur