Assert EventTypes references for IMC test #7899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
area/test-and-release
knative-prow
bot
added
the
size/XS
The id is different for each event when using container source. Use just the type, like other tests for container source.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7899 +/- ##
==========================================
- Coverage 69.22% 69.18% -0.04%
==========================================
Files 339 341 +2
Lines 19494 15816 -3678
==========================================
- Hits 13494 10943 -2551
+ Misses 5337 4200 -1137
- Partials 663 673 +10 ☔ View full report in Codecov by Sentry. |
knative-prow
bot
added
size/S
|
/hold For experimental tests to pass |
knative-prow
bot
added
the
do-not-merge/hold
|
Looks like after fixing the test for ContainerSource, it shows that no EventTypes are automatically created. Checking on Slack to see if this is expected. |
It is not supported.
mgencur
changed the title
knative-prow
bot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/test reconciler-tests |
2 similar comments
|
/test reconciler-tests |
|
/test reconciler-tests |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
/retest-required |
1 similar comment
|
/retest-required |
1 task
maschmid
pushed a commit
to maschmid/eventing
that referenced
this pull request
Sep 17, 2024
* Assert EventTypes references for IMC and ContainerSource test * Do not use ID as the attribute to match the event The id is different for each event when using container source. Use just the type, like other tests for container source. * Fix type * Remove test for ContainerSource EventType creation It is not supported.
pierDipi
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Sep 17, 2024
* Assert EventTypes references for IMC and ContainerSource test * Do not use ID as the attribute to match the event The id is different for each event when using container source. Use just the type, like other tests for container source. * Fix type * Remove test for ContainerSource EventType creation It is not supported. Co-authored-by: Martin Gencur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #7888
All of the tests should be asserting the eventtype's reference.
Proposed Changes
Pre-review Checklist
Release Note
Docs