Refactor DiscoveryImageSummary to DownloadIsoModal #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mareklibra
force-pushed
the
refactorToDownloadIsoModal
branch
3 times, most recently
from
eb97b5e to
ca9d4e1
Compare
mareklibra
force-pushed
the
refactorToDownloadIsoModal
branch
from
ca9d4e1 to
ff6d76f
Compare
mareklibra
changed the title
rawagner
approved these changes
May 24, 2021
jtomasek
suggested changes
May 25, 2021
| isOpen: boolean; | ||
| }; | ||
|
|
||
| const DownloadIsoModal: React.FC<DownloadIsoModalProps> = ({ isOpen, ...props }) => ( |
There was a problem hiding this comment.
Related to https://github.com/rawagner/dynamic-cim/pull/4/files/7df6d034c9670fb111ca7d47b34c1635a6d10b90#r638496136 Should we use modals from assisted-ui-lib or handle it on the console side?
There was a problem hiding this comment.
Commented there and on the slack. IMO, it would bring unnecessary complexity to provide that feature for both modal and non-modal usa-cases. The outer context still drives modal-related primitives and visibility (isOpen, onClose).
jtomasek
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: