Make HostsTable more generic #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawagner
force-pushed
the
generic_hoststable
branch
11 times, most recently
from
816d741 to
2049e4d
Compare
rawagner
changed the title
rawagner
force-pushed
the
generic_hoststable
branch
7 times, most recently
from
5a6ca31 to
8bbb58d
Compare
1 task
mareklibra
previously approved these changes
May 18, 2021
jtomasek
previously approved these changes
May 18, 2021
| setDiscoveryHintModalOpen?: HostsNotShowingLinkProps['setDiscoveryHintModalOpen']; | ||
| }; | ||
|
|
||
| const HostsTableCluster: React.FC<HostsTableClusterProps & WithTestID> = ({ |
There was a problem hiding this comment.
Nit: ClusterHostsTable might be a bit better.
There was a problem hiding this comment.
sounds good!
I also wonder - dont we want to move these generic components to some specific folder so we can have easier time identifying if its being reused in ACM/OCP or not ?
There was a problem hiding this comment.
I would not organize that for ACM/OCP. We are a library which is used in other contexts as well (+3).
We have already "naming contexts" on the top-level export. We can put some effort to better identify what to export/hide, recently we blindly reexport almost everything.
rawagner
force-pushed
the
generic_hoststable
branch
from
8bbb58d to
99f9bed
Compare
mareklibra
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes HostsTable to make it reusable for other environments.
The table now accepts callbacks for all actions so the consumer can use its own way of opening modals.
If no callback for the action is provided, then its not shown (the table becomes read-only)
Example of consuming the table is here https://github.com/rawagner/dynamic-cim/blob/infra_hosts/src/components/Agent/AgentTable.tsx#L24
The
AgentTablefetches Agent CR from k8s, maps the fields of the CR to format expected byHostsTable(we will need some util method to do this in the future). And passes the mapped hosts toHostsTable. Since no callbacks for the actions are provided, the table is in read-only mode.HostsTablein OpenShift ConsoleExpanded state
