This repository was archived by the owner on Jul 11, 2023. It is now read-only.
logs: make log level configurable through meshconfig #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change to trace through kubectl edit meshconfig reset to info through kubectl edit meshconfig |
Codecov Report
@@ Coverage Diff @@
## main #3650 +/- ##
==========================================
+ Coverage 67.05% 67.17% +0.12%
==========================================
Files 179 180 +1
Lines 8705 8741 +36
==========================================
+ Hits 5837 5872 +35
+ Misses 2837 2836 -1
- Partials 31 33 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Jun 23, 2021
shashankram
reviewed
Jun 23, 2021
cmd/osm-controller/osm-controller.go
Outdated
Comment on lines
371
to
373
| log.Info().Msgf("Global log level changed to: %s", logLevel) | ||
| currentLogLevel = logLevel | ||
| } |
There was a problem hiding this comment.
nit: seems unnecessary to log this because we would otherwise see an error.
New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes openservicemesh#3646 Signed-off-by: Eduard Serra <[email protected]>
shashankram
approved these changes
Jun 23, 2021
|
@Mergifyio backport release-v0.9 |
|
Command
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
osmLogLeveloption has been added under observability meshconfigspec (seems the most related and relevant to the available categories)
to allow changing the log level of OSM at runtime.
The initial log level flag has been kept as it still mandates boot log
level up to the point configurator and the log level handler are both
up, which then meshconfig value takes over.
The handler can't be easilly moved to the
loggerpackage as itintroduces a hard dependency cycle between logger<->configurator, hence
the handler has been left on osm-controller main.
Adds a unit test, and see below a working example on a running deployment.
Fixes #3646
Signed-off-by: Eduard Serra [email protected]
Description:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?