This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
OSM Controller's log level should be configurable via MeshConfig #3646
Assignees
Labels
area/logging
Logging related
Comments
|
I had something already, pushing. |
eduser25
added a commit
to eduser25/osm
that referenced
this issue
Jun 23, 2021
New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes openservicemesh#3646 Signed-off-by: Eduard Serra <[email protected]>
eduser25
added a commit
to eduser25/osm
that referenced
this issue
Jun 23, 2021
New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes openservicemesh#3646 Signed-off-by: Eduard Serra <[email protected]>
eduser25
added a commit
to eduser25/osm
that referenced
this issue
Jun 23, 2021
New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes openservicemesh#3646 Signed-off-by: Eduard Serra <[email protected]>
eduser25
added a commit
to eduser25/osm
that referenced
this issue
Jun 23, 2021
New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes openservicemesh#3646 Signed-off-by: Eduard Serra <[email protected]>
mergify bot
pushed a commit
that referenced
this issue
Jun 23, 2021
New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes #3646 Signed-off-by: Eduard Serra <[email protected]> (cherry picked from commit 0411db4) # Conflicts: # pkg/configurator/methods_test.go
eduser25
added a commit
to eduser25/osm
that referenced
this issue
Jun 23, 2021
(Backport release-v0.9) New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes openservicemesh#3646 Signed-off-by: Eduard Serra <[email protected]>
shalier
pushed a commit
to shalier/osm
that referenced
this issue
Jun 30, 2021
New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes openservicemesh#3646 Signed-off-by: Eduard Serra <[email protected]>
brunoterkaly
pushed a commit
to brunoterkaly/osm
that referenced
this issue
Jul 3, 2021
New `osmLogLevel` option has been added under observability meshconfig spec (seems the most related and relevant to the available categories) to allow changing the log level of OSM at runtime. The initial log level flag has been kept at it still mandates boot log level up to the point configurator and the log level handler are both up, which then meshconfig value takes over. The handler can't be easilly moved to the `logger` package as it introduces a hard dependency cycle between logger<->configurator, hence the handler has been left on osm-controller main. Adds a unit test, and see below a working example on a running deployment. Fixes openservicemesh#3646 Signed-off-by: Eduard Serra <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
OpenServiceMesh.controllerLogLevel should be configurable via MeshConfig.
This is currently only configurable via Helm chart value and cannot be easily changed without reinstalling OSM.
Being able to change the log level of the OSM Controller will be very useful for debugging issues.
The text was updated successfully, but these errors were encountered: