Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Consolidate metric/scrapping configuration #3065

Closed
eduser25 opened this issue Apr 1, 2021 · 1 comment · Fixed by openservicemesh/osm-docs#116
Closed

Consolidate metric/scrapping configuration #3065

eduser25 opened this issue Apr 1, 2021 · 1 comment · Fixed by openservicemesh/osm-docs#116
Assignees
Labels
size/L 14 days (~2.5 weeks)
Milestone

Comments

@eduser25
Copy link
Contributor

eduser25 commented Apr 1, 2021

Currently, to enable metric/scrapping config there are two steps to be taken:

1 - Enable prometheus_scrapping flag. This one mandates opening the listener to listen to Prometheus envoy port
on the pods, and allowing/proxying traffic through to the expected Prometheus endpoint on Envoy.
2 - Enable metrics on the namespace: This is done through CLI, and will:
(1) add the label on the namespace, and
(2) walk the namespace pods to add the Prometheus scrapping annotations to them.
By having the the namespace labeled with metrics label, new pods to come up in the namespace will be already patched
with the scrapping annotation by injector automatically.

This two steps could be coalesced under a single configuration story, such as enabling metrics on a Namespace. OSM could take care of both adding prometheus annotations, as well as issuing new configurations for the envoys to allow prometheus queries through.
There is the consideration of allowing individual envoys be annotated without having namespaces-metrics enabled, to support use cases where only individual envoys want to be scrapped on a namespace.

  • New Functionality [X]
  • Envoy Control Plane [X]
  • CLI Tool [X]
  • Metrics [X]
@eduser25 eduser25 added this to the v0.9.0 milestone Apr 1, 2021
@draychev draychev modified the milestones: v0.9.0, v0.10.0 May 21, 2021
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 3, 2021
This commit removes the prometheus_scraping flag and adds the envoy
prometheus scraping configs when a pod has the required prometheus annotation.

Part of openservicemesh#3065

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 3, 2021
This commit removes the prometheus_scraping flag and adds the envoy
prometheus scraping configs when a pod has the required prometheus annotation.

Part of openservicemesh#3065

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 3, 2021
This commit removes the prometheus_scraping flag and adds the envoy
prometheus scraping configs when a pod has the required prometheus annotation.

Part of openservicemesh#3065

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 4, 2021
This commit removes the prometheus_scraping flag and adds the envoy
prometheus scraping configs when a pod has the required prometheus annotation.

Part of openservicemesh#3065

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 4, 2021
This commit removes the prometheus_scraping flag and adds the envoy
prometheus scraping configs when a pod has the required prometheus annotation.

Part of openservicemesh#3065

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 4, 2021
This commit removes the prometheus_scraping flag and adds the envoy
prometheus scraping configs when a pod has the required prometheus annotation.

Part of openservicemesh#3065

Signed-off-by: Sneha Chhabria <[email protected]>
@snehachhabria
Copy link
Contributor

osm-docs repo needs to be updated with the relevant changes

shalier pushed a commit to shalier/osm that referenced this issue Jun 30, 2021
This commit removes the prometheus_scraping flag and adds the envoy
prometheus scraping configs when a pod has the required prometheus annotation.

Part of openservicemesh#3065

Signed-off-by: Sneha Chhabria <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L 14 days (~2.5 weeks)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants