This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 277
Consolidate metric/scrapping configuration #3065
Comments
Merged
snehachhabria
added a commit
to snehachhabria/osm
that referenced
this issue
Jun 3, 2021
This commit removes the prometheus_scraping flag and adds the envoy prometheus scraping configs when a pod has the required prometheus annotation. Part of openservicemesh#3065 Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria
added a commit
to snehachhabria/osm
that referenced
this issue
Jun 3, 2021
This commit removes the prometheus_scraping flag and adds the envoy prometheus scraping configs when a pod has the required prometheus annotation. Part of openservicemesh#3065 Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria
added a commit
to snehachhabria/osm
that referenced
this issue
Jun 3, 2021
This commit removes the prometheus_scraping flag and adds the envoy prometheus scraping configs when a pod has the required prometheus annotation. Part of openservicemesh#3065 Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria
added a commit
to snehachhabria/osm
that referenced
this issue
Jun 4, 2021
This commit removes the prometheus_scraping flag and adds the envoy prometheus scraping configs when a pod has the required prometheus annotation. Part of openservicemesh#3065 Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria
added a commit
to snehachhabria/osm
that referenced
this issue
Jun 4, 2021
This commit removes the prometheus_scraping flag and adds the envoy prometheus scraping configs when a pod has the required prometheus annotation. Part of openservicemesh#3065 Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria
added a commit
to snehachhabria/osm
that referenced
this issue
Jun 4, 2021
This commit removes the prometheus_scraping flag and adds the envoy prometheus scraping configs when a pod has the required prometheus annotation. Part of openservicemesh#3065 Signed-off-by: Sneha Chhabria <[email protected]>
osm-docs repo needs to be updated with the relevant changes |
shalier
pushed a commit
to shalier/osm
that referenced
this issue
Jun 30, 2021
This commit removes the prometheus_scraping flag and adds the envoy prometheus scraping configs when a pod has the required prometheus annotation. Part of openservicemesh#3065 Signed-off-by: Sneha Chhabria <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, to enable metric/scrapping config there are two steps to be taken:
1 - Enable
prometheus_scrapping
flag. This one mandates opening the listener to listen to Prometheus envoy porton the pods, and allowing/proxying traffic through to the expected Prometheus endpoint on Envoy.
2 - Enable metrics on the namespace: This is done through CLI, and will:
(1) add the label on the namespace, and
(2) walk the namespace pods to add the Prometheus scrapping annotations to them.
By having the the namespace labeled with metrics label, new pods to come up in the namespace will be already patched
with the scrapping annotation by injector automatically.
This two steps could be coalesced under a single configuration story, such as enabling metrics on a Namespace. OSM could take care of both adding prometheus annotations, as well as issuing new configurations for the envoys to allow prometheus queries through.
There is the consideration of allowing individual envoys be annotated without having namespaces-metrics enabled, to support use cases where only individual envoys want to be scrapped on a namespace.
The text was updated successfully, but these errors were encountered: