This repository was archived by the owner on Aug 8, 2023. It is now read-only.
remove Prometheus scraping reference from doc #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sneha Chhabria <[email protected]>
|
✔️ Deploy Preview for osm-docs ready! 🔨 Explore the source changes: 883dcae 🔍 Inspect the deploy log: https://app.netlify.com/sites/osm-docs/deploys/60bfd2a2e7de0c0008f14817 😎 Browse the preview: https://deploy-preview-116--osm-docs.netlify.app |
shashankram
approved these changes
Jun 8, 2021
| @@ -107,7 +89,7 @@ If Prometheus is found not to be scraping metrics for any Pods, perform the foll | |||
| Metrics successfully enabled in namespace [<namespace>] | |||
| ``` | |||
|
|
|||
| 1. If [custom metrics](/docs/tasks_usage/observability/metrics/#custom-metrics) are not being scraped, verify they have been enabled. | |||
| 2. If [custom metrics](/docs/tasks_usage/observability/metrics/#custom-metrics) are not being scraped, verify they have been enabled. | |||
There was a problem hiding this comment.
nit: 1. as before will render as bullet 2, so this change is unnecessary
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : openservicemesh/osm#3065
Signed-off-by: Sneha Chhabria [email protected]