Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI workflows on 1.x #888

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Oct 5, 2022

Signed-off-by: Yury-Fridlyand [email protected]

Description

See most recent workflow runs in https://github.com/Bit-Quill/opensearch-project-sql/actions?query=branch%3Adev-fix-ci-1.x

Issues Resolved

Fix failing CI workflows: https://github.com/opensearch-project/sql/actions/workflows/sql-test-and-build-workflow.yml?query=branch%3A1.x

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Fix java installation for SQL plugin workflow;
* Backport workbench CI fixes from opensearch-project#588 and opensearch-project#704.

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner October 5, 2022 16:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #888 (75c3da1) into 1.x (4a15c2f) will increase coverage by 32.33%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                1.x     #888       +/-   ##
=============================================
+ Coverage     62.91%   95.25%   +32.33%     
- Complexity        0     2746     +2746     
=============================================
  Files            10      276      +266     
  Lines           658     7416     +6758     
  Branches        119      546      +427     
=============================================
+ Hits            414     7064     +6650     
- Misses          191      298      +107     
- Partials         53       54        +1     
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...esponse/format/VisualizationResponseFormatter.java 100.00% <0.00%> (ø)
...rc/main/java/org/opensearch/sql/storage/Table.java 100.00% <0.00%> (ø)
...sql/expression/aggregation/VarianceAggregator.java 100.00% <0.00%> (ø)
...g/opensearch/sql/expression/LiteralExpression.java 100.00% <0.00%> (ø)
...g/opensearch/sql/data/model/AbstractExprValue.java 100.00% <0.00%> (ø)
...a/org/opensearch/sql/data/model/ExprByteValue.java 100.00% <0.00%> (ø)
...pensearch/sql/planner/logical/LogicalRelation.java 100.00% <0.00%> (ø)
...in/java/org/opensearch/sql/data/type/ExprType.java 100.00% <0.00%> (ø)
...rg/opensearch/sql/sql/config/SQLServiceConfig.java 100.00% <0.00%> (ø)
...protocol/response/format/CsvResponseFormatter.java 100.00% <0.00%> (ø)
... and 256 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yury-Fridlyand Yury-Fridlyand merged commit 4914f64 into opensearch-project:1.x Oct 6, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-fix-ci-1.x branch October 6, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants