Remove explicit node version for workbench #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
tmarkley
reviewed
Apr 22, 2022
| run: | | ||
| echo "::set-output name=node_version::$(node -p "(require('./OpenSearch-Dashboards/package.json').engines.node).match(/[.0-9]+/)[0]")" | ||
| echo "::set-output name=yarn_version::$(node -p "(require('./OpenSearch-Dashboards/package.json').engines.yarn).match(/[.0-9]+/)[0]")" | ||
|
|
||
| - name: Setup Node |
There was a problem hiding this comment.
Can you use the Dashboards .nvmrc file? Similar to what we do in Dashboards: https://github.com/tmarkley/OpenSearch-Dashboards/blob/c67b31e732995207ae432f24b393c902ec326b96/.github/workflows/build_and_test_workflow.yml#L32-L36
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
tmarkley
reviewed
Apr 22, 2022
| with: | ||
| node-version: '14.18.2' | ||
| node-version-file: ".nvmrc" |
There was a problem hiding this comment.
I think you have to point to the OpenSearch Dashboards directory to get this to work.
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
=========================================
Coverage 94.59% 94.59%
Complexity 2743 2743
=========================================
Files 276 276
Lines 7455 7455
Branches 551 551
=========================================
Hits 7052 7052
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mengweieric
approved these changes
Apr 22, 2022
kavithacm
approved these changes
Apr 22, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 22, 2022
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit a7d4395)
joshuali925
added a commit
that referenced
this pull request
Apr 25, 2022
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit a7d4395) Co-authored-by: Joshua Li <[email protected]>
Yury-Fridlyand
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Oct 5, 2022
…h-project#704. Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Oct 5, 2022
* Fix java installation for SQL plugin workflow; * Backport workbench CI fixes from opensearch-project#588 and opensearch-project#704. Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.