Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pplenabled to transport #2451

Merged

Conversation

zane-neo
Copy link
Contributor

@zane-neo zane-neo commented Dec 8, 2023

Description

Move pplenabled to transport main

Issues Resolved

Move pplenabled to transport main

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0176525) 95.40% compared to head (3162b81) 95.40%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2451   +/-   ##
=========================================
  Coverage     95.40%   95.40%           
  Complexity     5000     5000           
=========================================
  Files           479      479           
  Lines         13939    13939           
  Branches        937      937           
=========================================
  Hits          13299    13299           
  Misses          618      618           
  Partials         22       22           
Flag Coverage Δ
sql-engine 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dai-chen dai-chen added enhancement New feature or request backport 2.x labels Dec 8, 2023
penghuo
penghuo previously approved these changes Dec 8, 2023
@dai-chen
Copy link
Collaborator

dai-chen commented Dec 8, 2023

Please double check if failed CI relevant or not. Thanks!

dai-chen
dai-chen previously approved these changes Dec 8, 2023
Signed-off-by: zane-neo <[email protected]>
@zane-neo zane-neo dismissed stale reviews from dai-chen and penghuo via 3162b81 December 8, 2023 14:18
@zane-neo
Copy link
Contributor Author

zane-neo commented Dec 8, 2023

Please double check if failed CI relevant or not. Thanks!

Fixed the failure IT.

@dai-chen dai-chen mentioned this pull request Dec 8, 2023
6 tasks
@dai-chen dai-chen requested a review from penghuo December 8, 2023 18:16
@penghuo penghuo merged commit 797276d into opensearch-project:main Dec 12, 2023
22 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 12, 2023
* move pplenabled to transportaction

Signed-off-by: zane-neo <[email protected]>

* Fix IT failure and format code

Signed-off-by: zane-neo <[email protected]>

* Fix failure IT

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 797276d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Dec 18, 2023
* move pplenabled to transportaction



* Fix IT failure and format code



* Fix failure IT



---------


(cherry picked from commit 797276d)

Signed-off-by: zane-neo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants