move pplenabled to transportaction

[zane-neo]

Description

Move ppl_enabled configuration to transport action layer

Issues Resolved

Move ppl_enabled configuration to transport action layer

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4af150e) 95.41% compared to head (11d5eea) 95.45%.
Report is 2 commits behind head on 2.x.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #2444      +/-   ##
============================================
+ Coverage     95.41%   95.45%   +0.03%     
- Complexity     5022     5029       +7     
============================================
  Files           479      479              
  Lines         14072    14084      +12     
  Branches        933      936       +3     
============================================
+ Hits          13427    13444      +17     
+ Misses          625      618       -7     
- Partials         20       22       +2     

Flag	Coverage Δ
sql-engine	95.45% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dai-chen]

A few quick ask:

1. Could you open an issue with more context for all related PR?
2. Please check the CI failure

[dai-chen]

Synced offline. Thanks for the context! I think we're good for now if we want to depend on PPL module artifact directly.

In the long term, I think better solution would be PPL transport model class and Query DSL interface (proposed in High Level Option: Query DSL over Transport in #1327). This can be put and published in a new module for anyone who want to interact with SQL/PPL plugin.

[dai-chen]

just want to make sure we don't break anything, could you check if any existing IT cover this pplEnabled setting?

[zane-neo]

just want to make sure we don't break anything, could you check if any existing IT cover this pplEnabled setting?

Yes, there's IT covered this and that IT passed.

[dai-chen]

Thanks for the changes!

Could you change destination branch to main branch first? Normally we send PR against main with backport 2.x label.

[dai-chen]

Closing as new PR for main branch raised: #2451