-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed allowlist config to denylist ip config for datasource uri hosts #2042
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2042 +/- ##
============================================
- Coverage 97.28% 97.27% -0.02%
+ Complexity 4624 4623 -1
============================================
Files 409 410 +1
Lines 11943 11947 +4
Branches 828 828
============================================
+ Hits 11619 11621 +2
Misses 317 317
- Partials 7 9 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Have feedback on the report? Share it here. |
a451515
to
d902c23
Compare
6693567
to
729386d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the build failure. Thanks!
c46b631
to
1c4f916
Compare
fb22293
to
1158d43
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
…ts (#2042) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 9082a46) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.10 2.10
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.10
# Create a new branch
git switch --create backport/backport-2042-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9082a468ec670b6e69c36f98456f01d11086421e
# Push it to GitHub
git push --set-upstream origin backport/backport-2042-to-2.10
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.10 Then, create a pull request where the |
…ts (#2042) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 9082a46)
…ts (#2042) (#2059) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 9082a46)
…ts (#2042) (#2058) (cherry picked from commit 9082a46) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
plugins.query.datasources.uri.hosts.denylist
is the new property.Current Process of Validation:
127.0.0.0/8
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.