-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add denylist ip config for datasource endpoint #573
Conversation
3ec949f
to
a2b5c47
Compare
Codecov Report
@@ Coverage Diff @@
## main #573 +/- ##
============================================
+ Coverage 88.59% 89.03% +0.44%
- Complexity 753 767 +14
============================================
Files 92 93 +1
Lines 2717 2746 +29
Branches 221 223 +2
============================================
+ Hits 2407 2445 +38
+ Misses 230 221 -9
Partials 80 80
|
85ecc6e
to
f5a7664
Compare
@heemin32 what is the value of the denylist urls? Not able to find anything in this PR? |
For example, in cloud provider, they can maintain denylist so that customer cannot make request to internal services with escalated privilege because cluster is running in service account but not customer account. |
src/main/java/org/opensearch/geospatial/ip2geo/common/URLDenyListChecker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/geospatial/ip2geo/action/RestPutDatasourceHandler.java
Show resolved
Hide resolved
d81aa65
to
4a108ec
Compare
@heemin32 Build is failing with the latest changes. Pls fix it |
src/main/java/org/opensearch/geospatial/ip2geo/common/URLDenyListChecker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Heemin Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Just reviewed the PR to understand the use-case. |
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 35edec1)
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 35edec1)
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 35edec1) Co-authored-by: Heemin Kim <[email protected]>
Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 35edec1) Co-authored-by: Heemin Kim <[email protected]>
Description
Add a denylist ip config for datasource endpoint so that admin can block certain ip addresses from being used in datasource endpoint
This PR mimicked opensearch-project/sql#2042
When IP address is in the deny list, following message will be returned.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.