Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IT on 2.x - address breaking changes from upstream. #1659

Merged
merged 1 commit into from
May 25, 2023

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented May 25, 2023

Description

IT fails on 2.x branch (can't compile)

2023-05-25T18:49:40.0119575Z /home/runner/work/sql/sql/integ-test/src/test/java/org/opensearch/sql/legacy/OpenSearchSQLRestTestCase.java:36: error: package org.opensearch.core.internal.io does not exist
2023-05-25T18:49:40.0120005Z 
2023-05-25T18:49:40.0120688Z import org.opensearch.core.internal.io.IOUtils;

caused by opensearch-project/OpenSearch#7612
Fortunately, it is a simple fix.

on main it was fixed in scope of #1512, but this specific fix wasn't backported.

Issues Resolved

Fix CI on 2.x

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <[email protected]>
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1659 (f3670d2) into 2.x (3683b6c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1659   +/-   ##
=========================================
  Coverage     97.16%   97.16%           
  Complexity     4122     4122           
=========================================
  Files           371      371           
  Lines         10375    10375           
  Branches        704      704           
=========================================
  Hits          10081    10081           
  Misses          287      287           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MaxKsyunz MaxKsyunz merged commit c04dfb6 into opensearch-project:2.x May 25, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the fix-IT-in-2.x branch May 25, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants