-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Various Utilities, Assertion, and Concurrency Exception fr… #7612
Merged
gbbafna
merged 2 commits into
opensearch-project:2.x
from
linuxpi:backport/backport-6875-to-2.x
May 19, 2023
Merged
[Refactor] Various Utilities, Assertion, and Concurrency Exception fr… #7612
gbbafna
merged 2 commits into
opensearch-project:2.x
from
linuxpi:backport/backport-6875-to-2.x
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om server to libraries (opensearch-project#6875) To further reduce the surface area of utility methods in :server: this commit refactors the following: * MapBuilder from server module to common library * Assertions from server module to core library * BytesRef methods from CollectionUtils in server module to new BytesRefUtils in core library It also removes CollectionUtils dependency on hppc in prep for refactoring CollectionUtils methods to the proper library. Signed-off-by: Nicholas Walter Knize <[email protected]> (cherry picked from commit 0a20092)
linuxpi
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
May 17, 2023 17:52
linuxpi
force-pushed
the
backport/backport-6875-to-2.x
branch
from
May 17, 2023 17:58
6c9b9a1
to
bdadd41
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
linuxpi
force-pushed
the
backport/backport-6875-to-2.x
branch
from
May 19, 2023 06:57
bdadd41
to
3fd1886
Compare
Gradle Check (Jenkins) Run Completed with:
|
linuxpi
force-pushed
the
backport/backport-6875-to-2.x
branch
from
May 19, 2023 07:27
3fd1886
to
75a6e5f
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: bansvaru <[email protected]>
linuxpi
force-pushed
the
backport/backport-6875-to-2.x
branch
from
May 19, 2023 08:47
75a6e5f
to
9bb878a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7612 +/- ##
============================================
+ Coverage 70.21% 70.23% +0.02%
- Complexity 59862 59872 +10
============================================
Files 4882 4882
Lines 288328 288295 -33
Branches 41926 41920 -6
============================================
+ Hits 202457 202498 +41
+ Misses 68882 68875 -7
+ Partials 16989 16922 -67
|
gbbafna
approved these changes
May 19, 2023
5 tasks
6 tasks
MaxKsyunz
pushed a commit
to opensearch-project/sql
that referenced
this pull request
May 25, 2023
IT fails on 2.x branch (can't compile), caused by opensearch-project/OpenSearch#7612 Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…om server to libraries (#6875)
To further reduce the surface area of utility methods in :server: this commit refactors the following:
It also removes CollectionUtils dependency on hppc in prep for refactoring CollectionUtils methods to the proper library.
Signed-off-by: Nicholas Walter Knize [email protected]
(cherry picked from commit 0a20092)
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.