Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Various Utilities, Assertion, and Concurrency Exception fr… #7612

Merged
merged 2 commits into from
May 19, 2023

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented May 17, 2023

…om server to libraries (#6875)

To further reduce the surface area of utility methods in :server: this commit refactors the following:

  • MapBuilder from server module to common library
  • Assertions from server module to core library
  • BytesRef methods from CollectionUtils in server module to new BytesRefUtils in core library

It also removes CollectionUtils dependency on hppc in prep for refactoring CollectionUtils methods to the proper library.

Signed-off-by: Nicholas Walter Knize [email protected]
(cherry picked from commit 0a20092)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…om server to libraries (opensearch-project#6875)

To further reduce the surface area of utility methods in :server: this commit refactors the
following:

 * MapBuilder from server module to common library
 * Assertions from server module to core library
 * BytesRef methods from CollectionUtils in server module to
   new BytesRefUtils in core library

It also removes CollectionUtils dependency on hppc in prep for
refactoring CollectionUtils methods to the proper library.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit 0a20092)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi force-pushed the backport/backport-6875-to-2.x branch from bdadd41 to 3fd1886 Compare May 19, 2023 06:57
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi force-pushed the backport/backport-6875-to-2.x branch from 3fd1886 to 75a6e5f Compare May 19, 2023 07:27
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi linuxpi force-pushed the backport/backport-6875-to-2.x branch from 75a6e5f to 9bb878a Compare May 19, 2023 08:47
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #7612 (9bb878a) into 2.x (77f67db) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #7612      +/-   ##
============================================
+ Coverage     70.21%   70.23%   +0.02%     
- Complexity    59862    59872      +10     
============================================
  Files          4882     4882              
  Lines        288328   288295      -33     
  Branches      41926    41920       -6     
============================================
+ Hits         202457   202498      +41     
+ Misses        68882    68875       -7     
+ Partials      16989    16922      -67     
Impacted Files Coverage Δ
...a/org/opensearch/plugins/InstallPluginCommand.java 85.14% <ø> (ø)
...rc/main/java/org/opensearch/plugins/PluginCli.java 0.00% <ø> (ø)
...va/org/opensearch/plugins/RemovePluginCommand.java 85.48% <ø> (ø)
...src/main/java/org/opensearch/cli/MultiCommand.java 93.54% <ø> (ø)
...java/org/opensearch/common/collect/MapBuilder.java 66.66% <ø> (ø)
...in/java/org/opensearch/common/util/io/IOUtils.java 70.00% <ø> (ø)
...in/java/org/opensearch/common/util/io/Streams.java 94.11% <ø> (ø)
.../java/org/opensearch/common/util/net/NetUtils.java 68.75% <ø> (ø)
.../src/main/java/org/opensearch/core/Assertions.java 75.00% <ø> (ø)
...currency/OpenSearchRejectedExecutionException.java 100.00% <ø> (ø)
... and 138 more

... and 442 files with indirect coverage changes

@gbbafna gbbafna merged commit 7a6996b into opensearch-project:2.x May 19, 2023
@linuxpi linuxpi deleted the backport/backport-6875-to-2.x branch May 19, 2023 11:05
MaxKsyunz pushed a commit to opensearch-project/sql that referenced this pull request May 25, 2023
IT fails on 2.x branch (can't compile), caused by opensearch-project/OpenSearch#7612

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants