-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integ Test Refactoring #1383
Integ Test Refactoring #1383
Conversation
Signed-off-by: Vamsi Manohar <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #1383 +/- ##
=========================================
Coverage 98.38% 98.38%
Complexity 3698 3698
=========================================
Files 345 345
Lines 9113 9113
Branches 585 585
=========================================
Hits 8966 8966
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than verifying the workflow with github workflow, thanks for the changes!
Signed-off-by: Vamsi Manohar <[email protected]>
45efc3f
to
42b0005
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
42b0005
to
7fc8fcd
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: Vamsi Manohar <[email protected]>
integ-test/src/test/java/org/opensearch/sql/sql/CsvFormatIT.java
Outdated
Show resolved
Hide resolved
54dd12d
to
63f20bd
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
63f20bd
to
5611396
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
integ-test/src/test/java/org/opensearch/sql/sql/CsvFormatIT.java
Outdated
Show resolved
Hide resolved
scripts/integtest.sh
Outdated
yes | $OPENSEARCH_HOME/bin/opensearch-keystore add-file plugins.query.federation.datasources.config $OPENSEARCH_HOME/datasources.json | ||
|
||
if [ $SECURITY_ENABLED == "true" ] | ||
if [ $OS != "WindowsNT" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows doesn't have a uname or bash, I remember different uname gives different outputs on windows. which uname is this? maybe document prerequisite dependencies in case user wants to run tests on windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires Cygwin or MinGW packages and these are installed in the ami used in our build systems. Will mention it as a comment.
Signed-off-by: Vamsi Manohar <[email protected]>
86e661b
to
ac01ad5
Compare
CI failed? |
Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: Vamsi Manohar <[email protected]>
…to gitignore. Signed-off-by: Vamsi Manohar <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1383-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f6793ba63cb8c0301447276ae65a3e3f46563bd
# Push it to GitHub
git push --set-upstream origin backport/backport-1383-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main Then, create a pull request where the |
* Integ Test Refactoring Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 8f6793b)
* Integ Test Refactoring Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 8f6793b) Co-authored-by: vamsi-amazon <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1383-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8f6793ba63cb8c0301447276ae65a3e3f46563bd
# Push it to GitHub
git push --set-upstream origin backport/backport-1383-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main Then, create a pull request where the |
* Integ Test Refactoring Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 8f6793b)
* Integ Test Refactoring Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 8f6793b)
* Integ Test Refactoring Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 8f6793b)
…1393) * Integ Test Refactoring Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 8f6793b) Signed-off-by: Matthew Wells <[email protected]>
Description
Refactored to skip integ tests with datasources and prometheus in windows platform.
Changes Included:
org/opensearch/sql/ppl/PrometheusDataSourceCommandsIT.class
org/opensearch/sql/ppl/ShowDataSourcesCommandIT.class
,org/opensearch/sql/ppl/InformationSchemaCommandIT.class
in case of non-windows OS Types.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.