Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window abstraction into expression value system #1100

Conversation

dai-chen
Copy link
Collaborator

Signed-off-by: Chen Dai [email protected]

Description

TODO

Issues Resolved

#951

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #1100 (638dcfe) into 2.x (42143b9) will decrease coverage by 2.50%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #1100      +/-   ##
============================================
- Coverage     98.29%   95.79%   -2.51%     
- Complexity     3465     3480      +15     
============================================
  Files           347      356       +9     
  Lines          8645     9331     +686     
  Branches        550      668     +118     
============================================
+ Hits           8498     8939     +441     
- Misses          142      334     +192     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...expression/function/BuiltinFunctionRepository.java 100.00% <ø> (ø)
...n/java/org/opensearch/sql/utils/DateTimeUtils.java 100.00% <ø> (ø)
...ava/org/opensearch/sql/data/type/ExprCoreType.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...watermark/BoundedOutOfOrderWatermarkGenerator.java 100.00% <100.00%> (ø)
...search/sql/planner/streaming/windowing/Window.java 100.00% <100.00%> (ø)
...ing/windowing/assigner/TumblingWindowAssigner.java 100.00% <100.00%> (ø)
...windowing/trigger/AfterWatermarkWindowTrigger.java 100.00% <100.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen
Copy link
Collaborator Author

Need to republish the PR against main branch.

@dai-chen dai-chen closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants