Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window abstraction into expression value system #1064

Conversation

dai-chen
Copy link
Collaborator

Description

TODO: Will rebase and add detailed description

Issues Resolved

#951

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added the maintenance Improves code quality, but not the product label Nov 10, 2022
@dai-chen dai-chen self-assigned this Nov 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #1064 (574bd6f) into feature/maximus-m1 (3c6b37a) will decrease coverage by 2.53%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##             feature/maximus-m1    #1064      +/-   ##
========================================================
- Coverage                 98.27%   95.73%   -2.54%     
- Complexity                 3423     3438      +15     
========================================================
  Files                       342      350       +8     
  Lines                      8509     9196     +687     
  Branches                    542      660     +118     
========================================================
+ Hits                       8362     8804     +442     
- Misses                      142      334     +192     
- Partials                      5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/planner/optimizer/LogicalPlanOptimizer.java 100.00% <ø> (ø)
...n/java/org/opensearch/sql/utils/DateTimeUtils.java 100.00% <ø> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø)
...ava/org/opensearch/sql/data/type/ExprCoreType.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...expression/function/BuiltinFunctionRepository.java 100.00% <100.00%> (ø)
...l/planner/optimizer/rule/MergeFilterAndFilter.java 100.00% <100.00%> (ø)
...watermark/BoundedOutOfOrderWatermarkGenerator.java 100.00% <100.00%> (ø)
...search/sql/planner/streaming/windowing/Window.java 100.00% <100.00%> (ø)
...ing/windowing/assigner/TumblingWindowAssigner.java 100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen closed this Nov 23, 2022
@dai-chen
Copy link
Collaborator Author

Republish after rebase on 2.x branch: #1100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improves code quality, but not the product
Development

Successfully merging this pull request may close these issues.

2 participants