Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.4] Bump jackson to 2.14.0 #1058

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Nov 9, 2022

Signed-off-by: Joshua Li [email protected]

Description

bump to be consistent with core 2.4 branch: opensearch-project/OpenSearch@7c184ab

Issues Resolved

closes #1057

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 requested a review from a team as a code owner November 9, 2022 01:50
@joshuali925 joshuali925 changed the title Bump jackson to 2.14.0 [2.4] Bump jackson to 2.14.0 Nov 9, 2022
@Yury-Fridlyand Yury-Fridlyand self-requested a review November 9, 2022 01:56
@Yury-Fridlyand
Copy link
Collaborator

What's wrong with CI?

@joshuali925
Copy link
Member Author

What's wrong with CI?

OpenSearch snapshot is building in progress, so CI is still pulling down old opensearch. will rerun a bit later

@codecov-commenter
Copy link

Codecov Report

Merging #1058 (1ad073a) into 2.4 (d3bb902) will decrease coverage by 35.49%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.4    #1058       +/-   ##
=============================================
- Coverage     98.26%   62.76%   -35.50%     
=============================================
  Files           324       10      -314     
  Lines          8413      658     -7755     
  Branches        553      119      -434     
=============================================
- Hits           8267      413     -7854     
- Misses          142      192       +50     
- Partials          4       53       +49     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/opensearch/sql/analysis/HighlightAnalyzer.java
...rch/sql/expression/aggregation/TakeAggregator.java
...arch/sql/expression/datetime/DateTimeFunction.java
...org/opensearch/sql/sql/domain/SQLQueryRequest.java
...arch/planner/logical/rule/MergeAggAndRelation.java
...l/planner/physical/catalog/CatalogTableSchema.java
.../opensearch/sql/data/model/ExprTimestampValue.java
...rg/opensearch/sql/data/model/ExprBooleanValue.java
...nsearch/sql/analysis/WindowExpressionAnalyzer.java
...opensearch/planner/physical/MLCommonsOperator.java
... and 324 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuali925 joshuali925 merged commit 5a1adb2 into opensearch-project:2.4 Nov 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 5a1adb2)
dai-chen added a commit that referenced this pull request Nov 9, 2022
* Fix `FLOAT` -> `DOUBLE` cast. (#1025)

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix error messaging from prometheus. (#1029) (#1037)

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit 4a9cef3)

Co-authored-by: vamsi-amazon <[email protected]>

* Add `query` function as alternate syntax to `query_string` function (#1010)

This maintains backwards compatibility with the v1 engine.

* Update DATE and TIME functions to parse string input as datetime (#991)

Add option to accept datetime like string in both TIME and DATE (eg. accept "1999-01-02 12:12:12" for both TIME and DATE.

Strict check on date for testing for valid dates (eg. Don't accept Feb 30th as a valid date) and throws a SemanticCheckException.

Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: MitchellGale-BitQuill <[email protected]>

* back quote fix (#1041) (#1050)

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit d3bb902)

Co-authored-by: vamsi-amazon <[email protected]>

* Catalog to Datasource changes (#1027) (#1049)

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit 3e30379)

* Bump jackson to 2.14.0 (#1058)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 5a1adb2)

* Add valueOf() to Expression (#1055)

Signed-off-by: Joshua Li <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: MitchellGale-BitQuill <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <[email protected]>
Co-authored-by: GabeFernandez310 <[email protected]>
Co-authored-by: MitchellGale-BitQuill <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1058-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a1adb236f5589dfd10aa17783f13684b70a3c51
# Push it to GitHub
git push --set-upstream origin backport/backport-1058-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1058-to-main.

Yury-Fridlyand pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Nov 10, 2022
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 5a1adb2)
Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] OS Distribution Build Failed for sql-3.0.0 [AUTOCUT] OS Distribution Build Failed for sql-2.4.0
8 participants