Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport main] Bump jackson to 2.14.0 (#1058) #1066

Closed
wants to merge 1 commit into from
Closed

[Backport main] Bump jackson to 2.14.0 (#1058) #1066

wants to merge 1 commit into from

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Joshua Li [email protected]
(cherry picked from commit 5a1adb2)
Signed-off-by: Yury-Fridlyand [email protected]

Description

Backport #1058 to main.

Issues Resolved

Fixes #1065

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 @Yury-Fridlyand
Bump jackson to 2.14.0 (opensearch-project#1058)
00d18b9 
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 5a1adb2)
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner November 10, 2022 17:25
joshuali925
joshuali925 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, core snapshot not updated

3.0.0-SNAPSHOT/ | Thu Nov 03 08:32:01 UTC 2022

@Yury-Fridlyand Yury-Fridlyand marked this pull request as draft November 10, 2022 19:41
@joshuali925
Copy link
Member

not sure what this is, checking

> Task :integ-test:test FAILED
Error occurred during initialization of VM
java.lang.Error: Could not create SecurityManager
	at java.lang.System.initPhase3([email protected]/System.java:2065)
Caused by: java.lang.ClassNotFoundException: allow
	at jdk.internal.loader.BuiltinClassLoader.loadClass([email protected]/BuiltinClassLoader.java:581)

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022 •
edited
Loading

Codecov Report

Merging #1066 (00d18b9) into main (6c0d7c6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1066   +/-   ##
=========================================
  Coverage     94.83%   94.83%           
  Complexity     2916     2916           
=========================================
  Files           291      291           
  Lines          7795     7795           
  Branches        568      568           
=========================================
  Hits           7392     7392           
  Misses          349      349           
  Partials         54       54
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuali925
Copy link
Member

upstream issue opensearch-project/opensearch-build#2886

@MitchellGale MitchellGale mentioned this pull request Nov 15, 2022
Merged
6 tasks
@penghuo
Copy link
Collaborator

penghuo commented Dec 13, 2022

could we close this PR? main using 2.14.1 now, and will auto sync with OpenSearch core in future. #1169

@Yury-Fridlyand
Copy link
Collaborator Author

Ok

@Yury-Fridlyand Yury-Fridlyand deleted the backport/backport-1058-to-main branch December 14, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchellGale MitchellGale MitchellGale approved these changes

@ohltyler ohltyler ohltyler approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@ps48 ps48 Awaiting requested review from ps48 ps48 will be requested when the pull request is marked ready for review ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm will be requested when the pull request is marked ready for review kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho will be requested when the pull request is marked ready for review derek-ho is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB will be requested when the pull request is marked ready for review YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric will be requested when the pull request is marked ready for review mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis will be requested when the pull request is marked ready for review Swiddis is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az will be requested when the pull request is marked ready for review seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha will be requested when the pull request is marked ready for review anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey will be requested when the pull request is marked ready for review forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto will be requested when the pull request is marked ready for review acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG will be requested when the pull request is marked ready for review GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 will be requested when the pull request is marked ready for review ykmr1224 is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin will be requested when the pull request is marked ready for review LantaoJin is a code owner

@noCharger noCharger Awaiting requested review from noCharger noCharger will be requested when the pull request is marked ready for review noCharger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yury-Fridlyand @joshuali925 @codecov-commenter @penghuo @ohltyler @MitchellGale