Fix for errors in prometheus connector when backquotes are used for fieldnames in aggregations.

[vmmusings]

Signed-off-by: vamsi-amazon [email protected]

Description

Backquotes in stats groupby list is causing errors in prometheus connector.
Eg command:

source=prometheus.promhttp_metric | stats avg(@value) by span(@timestamp, 15s), `instance`

Issues Resolved

[List any issues this PR will resolve]

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1041 (77588fd) into 2.4 (4a9cef3) will decrease coverage by 2.57%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.4    #1041      +/-   ##
============================================
- Coverage     98.26%   95.68%   -2.58%     
- Complexity     3326     3332       +6     
============================================
  Files           324      334      +10     
  Lines          8400     9071     +671     
  Branches        553      672     +119     
============================================
+ Hits           8254     8680     +426     
- Misses          142      334     +192     
- Partials          4       57      +53     

Flag	Coverage Δ
query-workbench	62.76% <ø> (?)
sql-engine	98.26% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...us/storage/model/PrometheusResponseFieldNames.java	100.00% <ø> (ø)
...ch/sql/prometheus/response/PrometheusResponse.java	100.00% <100.00%> (ø)
...rage/implementor/PrometheusDefaultImplementor.java	100.00% <100.00%> (ø)
.../storage/querybuilder/AggregationQueryBuilder.java	100.00% <100.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx	100.00% <0.00%> (ø)
workbench/public/components/PPLPage/PPLPage.tsx	56.52% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx	68.32% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx	61.60% <0.00%> (ø)
workbench/public/application.tsx	0.00% <0.00%> (ø)
workbench/public/components/app.tsx	0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Yury-Fridlyand]

Backquotes could be used to wrap any identifier. Could you, please, test a more complex scenario?

source=`prometheus`.`promhttp_metric` | stats avg(@value) as `agg` by span(@timestamp, 15s), `instance`, `handler`, `job`

[vmmusings]

Backquotes could be used to wrap any identifier. Could you, please, test a more complex scenario?

source=`prometheus`.`promhttp_metric` | stats avg(@value) as `agg` by span(@timestamp, 15s), `instance`, `handler`, `job`

Sure

[penghuo]

https://github.com/opensearch-project/sql/blob/2.x/ppl/src/main/java/org/opensearch/sql/ppl/parser/AstExpressionBuilder.java#L365

Is it covered by Parser?

Yes, Kind of covered.

NamedExpression

{
 name :  \`instance\`
 refExpression : {
  attr : "instance"
  }
 }

I can rely on ReferenceExpression instead of stripping the backquotes.