[Backport 2.x] [Enhancement] Replace JUnit assertEquals() with Hamcrest matchers assertThat() #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhas Kurapati <[email protected]>
prabhask5
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
DarshitChanpura
previously approved these changes
Jul 10, 2024
|
Done! @DarshitChanpura |
Signed-off-by: Prabhas Kurapati <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #4545 +/- ##
==========================================
- Coverage 65.18% 65.13% -0.06%
==========================================
Files 313 313
Lines 21942 21942
Branches 3556 3556
==========================================
- Hits 14302 14291 -11
- Misses 5859 5866 +7
- Partials 1781 1785 +4 |
RyanL1997
approved these changes
Jul 11, 2024
DarshitChanpura
merged commit 3149e76
into
opensearch-project:2.x
77 of 78 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #4544 to branch 2.x.
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Enhancement
Why these changes are required?
Refer to: [Test Refactoring] Replace
Assert.assertEquals()withassertThat()#1832What is the old behavior before changes and new behavior after changes?
Nothing ideally.
Issues Resolved
#3680
#1832
Is this a backport? If so, please add backport PR # and/or commits #
Yes backport from #4544
Manual backport was required due to conflicts created due to certain assertion values changing alongside the formatting and function change.
Testing
N/A, changed tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.