-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Replace JUnit assertEquals() with Hamcrest matchers assertThat() #4544
[Enhancement] Replace JUnit assertEquals() with Hamcrest matchers assertThat() #4544
Conversation
Signed-off-by: Prabhas Kurapati <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
@scrawfor99 @cwperks @DarshitChanpura Ready for review! Had some commit issues in the previous PR. |
Signed-off-by: Prabhas Kurapati <[email protected]>
Signed-off-by: Prabhas Kurapati <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4544 +/- ##
==========================================
+ Coverage 64.99% 65.00% +0.01%
==========================================
Files 314 314
Lines 22111 22111
Branches 3566 3566
==========================================
+ Hits 14370 14374 +4
+ Misses 5955 5951 -4
Partials 1786 1786 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done @prabhask5
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4544-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b2109a5d50dc5ae16a1ccd641645433b9da8a7c
# Push it to GitHub
git push --set-upstream origin backport/backport-4544-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
@prabhask5 mind creating a manual backport to 2.x? |
Description
As per this issue: #1832, changed all occurrences of Assert.assertEquals to assertThat, additionally changed imports accordingly.
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Enhancement
Why these changes are required?
Refer to: [Test Refactoring] Replace
Assert.assertEquals()
withassertThat()
#1832What is the old behavior before changes and new behavior after changes?
Nothing ideally.
Issues Resolved
#3680
#1832
Is this a backport? If so, please add backport PR # and/or commits #
No
Testing
N/A, changed tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.