-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use predictable serialization logic for transport headers #4264
Use predictable serialization logic for transport headers #4264
Conversation
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
src/main/java/org/opensearch/security/transport/SecurityInterceptor.java
Outdated
Show resolved
Hide resolved
…ilzer Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
src/test/java/org/opensearch/security/transport/SecurityInterceptorTests.java
Show resolved
Hide resolved
src/main/java/org/opensearch/security/transport/SecurityInterceptor.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4264 +/- ##
==========================================
+ Coverage 66.06% 66.08% +0.01%
==========================================
Files 301 302 +1
Lines 21711 21723 +12
Branches 3506 3509 +3
==========================================
+ Hits 14343 14355 +12
- Misses 5607 5609 +2
+ Partials 1761 1759 -2
|
Note; BWC tests are failing because 2.14 needs the updated behavior - making the change directly in #4288 |
@DarshitChanpura @scrawfor99 Mind taking a look at this version of the change, nearly the same as #4288 |
…-project#4264) Signed-off-by: Peter Nied <[email protected]>
Description
This change will prevent new clusters from using the 'custom serialization' format that was causing performance impact with customers in OpenSearch 2.11.
Background: the serialization changes from #2802 introduced issues where for certain serialization headers that were previously very small for over the wire transmission become much larger. The root cause of this was that the JDK serialization process was able to detect duplicate entries and then use an encoding format to make it compressible. Adding this logic into the serialization system from OpenSearch is non-trivial and is not being invested in.
Issues Resolved
Testing
BWC test should cover the scenarios
Before leaving draft, going to build tests that verify larger thread constructors are serialized in a compatible way.
Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.