Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Environment variable for choosing serialisation - JDK or custom #4227

Closed
Dhruvan1217 opened this issue Apr 9, 2024 · 3 comments · Fixed by #4264
Closed

Introduce Environment variable for choosing serialisation - JDK or custom #4227

Dhruvan1217 opened this issue Apr 9, 2024 · 3 comments · Fixed by #4264
Assignees
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@Dhruvan1217
Copy link

Is your feature request related to a problem?
Currently, In some cases, users are having problems (#4085) while upgrading from 2.10 to 2.11+ where it switches the serialisation to custom serialisation technique (Ref: #2780) and have shard allocation issues.

What solution would you like?

  • We can introduce an environment variable like USE_JDK_SERIALIZATION=true (Boolean) to allow the users to choose what serialisation they want to choose until all the corner cases are sorted for using custom serialisation.
  • Maybe default value for USE_JDK_SERIALIZATION is false if we think the custom serialisation is faster.
@Dhruvan1217 Dhruvan1217 added enhancement New feature or request untriaged Require the attention of the repository maintainers and may need to be prioritized labels Apr 9, 2024
@cwperks
Copy link
Member

cwperks commented Apr 9, 2024

Thank you for filing this request @Dhruvan1217. @parasjain1 do you have any concerns with introducing a setting (something like plugins.security.use_jdk_serialization) that will explicitly tell a cluster to use JDK serialization? There is a ConfigConstant for this, but it is not read in as a setting and used where the serialization format is determined.

@stephen-crawford
Copy link
Contributor

[Triage] Hi @Dhruvan1217 thanks for filing this issue. @parasjain1 could you please provide your input on this request and make a contribution towards resolving the backwards compatibility issue. Otherwise we will have to pull the feature in the next version release.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Apr 15, 2024
@peternied
Copy link
Member

I'll be looking into this, I don't think we should add a feature flag, but I'll address the upgrade problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants