Update ci.yml to use upload-artifact@v4 for better build time

[nicheexpress]

upload-artifact@v4 is 10x faster (according to GitHub), It has significantly reduced build time

https://github.blog/2024-02-12-get-started-with-v4-of-github-actions-artifacts/

[peternied]

Thanks for the contribution, without being paired with the download artifact of the same version this will cause failures. Please look into a previous pull request [1] that updated this into main.

I recommend creating new pull request following the backport workflow [2] to get this functionality into this 1.3 branch.

• [1] Fix the CI / report-coverage check by switching to corresponding actions/upload-artifact@v4 #3893
• [2] Fix the CI / report-coverage check by switching to corresponding actions/upload-artifact@v4 #3893 (comment)

[nicheexpress]

Thanks @peternied, I believe that download-artifact does not exists in 1.3 it was introduced later on

[peternied]

It was added later, in this repository we use backporting workflows [1] to move code from the main branch out to current major versions and minor versions. If you'd like to get this change into this branch I'd recommend following that process.

Note; since this branch is maintained for security updates. We've got a high barrier to entry for changes to it - I'm on the fence if your proposed change meets that bar. If you are looking to make improvements with more impact, I would suggest looking at the main branch.

• [1] https://github.com/opensearch-project/.github/blob/main/RELEASING.md#backporting

[nicheexpress]

Thanks @peternied I've learned something new :)
I've opened a new PR by following the guide above