Fix the CI / report-coverage check by switching to corresponding actions/upload-artifact@v4 #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
reta
reviewed
Dec 22, 2023
reta
approved these changes
Dec 22, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3893 +/- ##
==========================================
- Coverage 66.58% 65.18% -1.41%
==========================================
Files 298 298
Lines 21188 21189 +1
Branches 3453 3454 +1
==========================================
- Hits 14109 13811 -298
- Misses 5363 5666 +303
+ Partials 1716 1712 -4
|
peternied
approved these changes
Dec 22, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3893-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83723432cca6e78d23e034b5149ff72d5907fde3
# Push it to GitHub
git push --set-upstream origin backport/backport-3893-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
|
Creating a manual backport |
cwperks
added a commit
to cwperks/security
that referenced
this pull request
Dec 22, 2023
…ons/upload-artifact@v4 (opensearch-project#3893) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 8372343)
cwperks
added a commit
that referenced
this pull request
Dec 22, 2023
…responding actions/upload-artifact@v4 (#3893) (#3895) Backport #3893 to 2.x --------- Signed-off-by: Craig Perkins <[email protected]>
prabhask5
pushed a commit
to prabhask5/opensearch-security
that referenced
this pull request
Jan 11, 2024
…ons/upload-artifact@v4 (opensearch-project#3893) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Prabhas Kurapati <[email protected]>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
…ons/upload-artifact@v4 (opensearch-project#3893) Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the CI / report-coverage check by using the corresponding upload artifact package. I verified this change by creating a PR on my local fork and checked that the artifacts are uploaded to the CI summary after the build is complete.
Maintenance
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.