Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors reRequestAuthentication to call notifyIpAuthFailureListener before sending the response to the channel #3411

Merged
merged 5 commits into from
Oct 3, 2023

Cleans up some left-over comments

9185eab
Select commit
Loading
Failed to load commit list.
Merged

Refactors reRequestAuthentication to call notifyIpAuthFailureListener before sending the response to the channel #3411

Cleans up some left-over comments
9185eab
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch succeeded Sep 27, 2023 in 4s

70.83% of diff hit (target 64.23%)

View this Pull Request on Codecov

70.83% of diff hit (target 64.23%)

Annotations

Check warning on line 241 in src/main/java/com/amazon/dlic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/amazon/dlic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java#L241 

Added line #L241 was not covered by tests

Check warning on line 176 in src/main/java/com/amazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/amazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java#L176 

Added line #L176 was not covered by tests

Check warning on line 297 in src/main/java/com/amazon/dlic/auth/http/kerberos/HTTPSpnegoAuthenticator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/amazon/dlic/auth/http/kerberos/HTTPSpnegoAuthenticator.java#L297 

Added line #L297 was not covered by tests

Check warning on line 300 in src/main/java/com/amazon/dlic/auth/http/kerberos/HTTPSpnegoAuthenticator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/amazon/dlic/auth/http/kerberos/HTTPSpnegoAuthenticator.java#L300 

Added line #L300 was not covered by tests

Check warning on line 240 in src/main/java/com/amazon/dlic/auth/http/saml/AuthTokenProcessorHandler.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/amazon/dlic/auth/http/saml/AuthTokenProcessorHandler.java#L240 

Added line #L240 was not covered by tests

Check warning on line 288 in src/main/java/org/opensearch/security/auth/BackendRegistry.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/security/auth/BackendRegistry.java#L288 

Added line #L288 was not covered by tests

Check warning on line 305 in src/main/java/org/opensearch/security/auth/BackendRegistry.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/security/auth/BackendRegistry.java#L305 

Added line #L305 was not covered by tests

Check warning on line 310 in src/main/java/org/opensearch/security/auth/BackendRegistry.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/security/auth/BackendRegistry.java#L309-L310 

Added lines #L309 - L310 were not covered by tests

Check warning on line 93 in src/main/java/org/opensearch/security/http/HTTPProxyAuthenticator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/security/http/HTTPProxyAuthenticator.java#L93 

Added line #L93 was not covered by tests

Check warning on line 247 in src/main/java/org/opensearch/security/http/OnBehalfOfAuthenticator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/security/http/OnBehalfOfAuthenticator.java#L247 

Added line #L247 was not covered by tests
View more details on Codecov