-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] [2.x] dependabot: bump com.google.errorprone:error_prone_annotations from 2.21.1 to 2.22.0 (#3393) #3403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….21.1 to 2.22.0 (opensearch-project#3393) Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.21.1 to 2.22.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/error-prone/releases">com.google.errorprone:error_prone_annotations's releases</a>.</em></p> <blockquote> <h2>Error Prone 2.22.0</h2> <p>We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see <a href="https://redirect.github.com/google/error-prone/issues/3803">#3803</a>. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass <code>--release 11</code> to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on <a href="https://redirect.github.com/google/error-prone/issues/3803">#3803</a>.</p> <p>New checks:</p> <ul> <li><a href="https://errorprone.info/bugpattern/ClosingStandardOutputStreams"><code>ClosingStandardOutputStreams</code></a>: Prevents accidentally closing <code>System.{out,err}</code> with try-with-resources</li> <li><a href="https://errorprone.info/bugpattern/TruthContainsExactlyElementsInUsage"><code>TruthContainsExactlyElementsInUsage</code></a>: <code>containsExactly</code> is preferred over <code>containsExactlyElementsIn</code> when creating new iterables</li> <li><a href="https://errorprone.info/bugpattern/UnnecessaryAsync"><code>UnnecessaryAsync</code></a>: detects unnecessary use of async primitives in local (and hence single-threaded) scopes</li> <li><a href="https://errorprone.info/bugpattern/ReturnAtTheEndOfVoidFunction"><code>ReturnAtTheEndOfVoidFunction</code></a>: detects unnecessary <code>return</code> statements at the end of <code>void</code> functions</li> <li><a href="https://errorprone.info/bugpattern/MultimapKeys"><code>MultimapKeys</code></a>: Suggests using <code>keySet()</code> instead of iterating over <code>Multimap.keys()</code>, which does not collapse duplicates</li> </ul> <p>Bug fixes and improvements:</p> <ul> <li>Don't complain about literal IP addresses in <code>AddressSelection</code> (<a href="https://github.com/google/error-prone/commit/44b65527debbc57892f21ca3ba458b16771e423e">https://github.com/google/error-prone/commit/44b65527debbc57892f21ca3ba458b16771e423e</a>)</li> <li>Prevent SuggestedFixes#renameMethod from modifying return type declaration (<a href="https://redirect.github.com/google/error-prone/issues/4043">#4043</a>)</li> <li>Fix UnusedVariable false positives for private record parameters (<a href="https://redirect.github.com/google/error-prone/issues/2713">#2713</a>)</li> <li>When running in conservative mode, no longer assume that implementations of <code>Map.get</code>, etc. return <code>null</code> (<a href="https://redirect.github.com/google/error-prone/issues/2910">#2910</a>)</li> <li>CanIgnoreReturnValueSuggester: Support additional exempting method annotations (<a href="https://redirect.github.com/google/error-prone/issues/4009">#4009</a>)</li> <li>UnusedVariable: exclude junit5's <code>@RegisterExtension</code> (<a href="https://redirect.github.com/google/error-prone/issues/3892">#3892</a>)</li> <li>Support running all available patch checks (<a href="https://redirect.github.com/google/error-prone/issues/947">#947</a>)</li> <li>Upgrade java-diff-utils 4.0 -> 4.12 (<a href="https://redirect.github.com/google/error-prone/issues/4081">#4081</a>)</li> <li>Flag unused Refaster template parameters (<a href="https://redirect.github.com/google/error-prone/issues/4060">#4060</a>)</li> <li>Support <code>@SuppressWarnings("all")</code> (<a href="https://redirect.github.com/google/error-prone/issues/4065">#4065</a>)</li> <li>Prevent Refaster <code>UMemberSelect</code> from matching method parameters (<a href="https://redirect.github.com/google/error-prone/issues/2456">#2456</a>)</li> <li>MissingDefault : Don't require <code>// fall out</code> comments on expression switches (<a href="https://redirect.github.com/google/error-prone/issues/2709">#2709</a>)</li> <li>Skip UnnecessaryLambda findings for usages in enhanced for loops (<a href="https://redirect.github.com/google/error-prone/issues/2518">#2518</a>)</li> <li>Fix bug where nested MissingBraces violations' suggested fixes result in broken code (<a href="https://redirect.github.com/google/error-prone/issues/3797">#3797</a>)</li> <li>Add support for specifying <code>exemptPrefixes</code>/<code>exemptNames</code> for UnusedVariable via flags (<a href="https://redirect.github.com/google/error-prone/issues/2753">#2753</a>)</li> <li>UnusedMethod: Added exempting variable annotations (<a href="https://redirect.github.com/google/error-prone/issues/2881">#2881</a>)</li> </ul> <p>Full Changelog: <a href="https://github.com/google/error-prone/compare/v2.21.1...v2.22.0">https://github.com/google/error-prone/compare/v2.21.1...v2.22.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/google/error-prone/commit/7114c31a8819c5b5debd4506f7aca5fd4fe6bc15"><code>7114c31</code></a> Release Error Prone 2.22.0</li> <li><a href="https://github.com/google/error-prone/commit/c94d74da01c750923eb51c9bfeb274ddacaea012"><code>c94d74d</code></a> Update release.yml - temporarily disable sonatype deployments</li> <li><a href="https://github.com/google/error-prone/commit/080411ec38e78e8677afa61cbf3fd061b7923134"><code>080411e</code></a> Added exempting variable annotations</li> <li><a href="https://github.com/google/error-prone/commit/737dec07570ae14f71c808281187adbb5cd947cb"><code>737dec0</code></a> Remove DiffNotApplicableException</li> <li><a href="https://github.com/google/error-prone/commit/f3a2bf8ea5bf9687cb7a42ad25db01dfb96cb84e"><code>f3a2bf8</code></a> Update ci.yml for JDK 21 release</li> <li><a href="https://github.com/google/error-prone/commit/1d2bc93bfab99cc08f96e9c4c534a829ece8da2b"><code>1d2bc93</code></a> Introduce <code>ErrorProneFlags.get{Set,List}OrEmpty</code>, because basically every cal...</li> <li><a href="https://github.com/google/error-prone/commit/1bec842493f2fabbb808e0d8f2074083df5b742f"><code>1bec842</code></a> Fix a crash in UnnecessaryAsync</li> <li><a href="https://github.com/google/error-prone/commit/d2ee28e8576e5b23cb7538078e1b75484af9c15a"><code>d2ee28e</code></a> Fix a crash in TimeUnitConversionChecker</li> <li><a href="https://github.com/google/error-prone/commit/ac424d0ce91c9ccb89be611f5e915d384df19d5b"><code>ac424d0</code></a> Tighten the return types in Fix.</li> <li><a href="https://github.com/google/error-prone/commit/58e5bb8a3cf65b800102832d6fe65a55e46161c4"><code>58e5bb8</code></a> Update and wordsmith the <code>@CompileTimeConstant</code> documentation to reflect chan...</li> <li>Additional commits viewable in <a href="https://github.com/google/error-prone/compare/v2.21.1...v2.22.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.google.errorprone:error_prone_annotations&package-manager=gradle&previous-version=2.21.1&new-version=2.22.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 826bdeb)
reta
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
willyborankin
as code owners
September 25, 2023 13:13
reta
changed the title
dependabot: bump com.google.errorprone:error_prone_annotations from 2.21.1 to 2.22.0 (#3393)
[Backport] [2.x] dependabot: bump com.google.errorprone:error_prone_annotations from 2.21.1 to 2.22.0 (#3393)
Sep 25, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #3403 +/- ##
============================================
- Coverage 64.11% 64.10% -0.01%
Complexity 3367 3367
============================================
Files 256 256
Lines 19515 19515
Branches 3297 3297
============================================
- Hits 12512 12511 -1
- Misses 5360 5362 +2
+ Partials 1643 1642 -1 |
Closing in favour of #3400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3393 to `2.x