Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: bump com.google.errorprone:error_prone_annotations from 2.21.1 to 2.22.0 #3393

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 25, 2023

Bumps com.google.errorprone:error_prone_annotations from 2.21.1 to 2.22.0.

Release notes

Sourced from com.google.errorprone:error_prone_annotations's releases.

Error Prone 2.22.0

We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass --release 11 to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #3803.

New checks:

Bug fixes and improvements:

  • Don't complain about literal IP addresses in AddressSelection (google/error-prone@44b6552)
  • Prevent SuggestedFixes#renameMethod from modifying return type declaration (#4043)
  • Fix UnusedVariable false positives for private record parameters (#2713)
  • When running in conservative mode, no longer assume that implementations of Map.get, etc. return null (#2910)
  • CanIgnoreReturnValueSuggester: Support additional exempting method annotations (#4009)
  • UnusedVariable: exclude junit5's @RegisterExtension (#3892)
  • Support running all available patch checks (#947)
  • Upgrade java-diff-utils 4.0 -> 4.12 (#4081)
  • Flag unused Refaster template parameters (#4060)
  • Support @SuppressWarnings("all") (#4065)
  • Prevent Refaster UMemberSelect from matching method parameters (#2456)
  • MissingDefault : Don't require // fall out comments on expression switches (#2709)
  • Skip UnnecessaryLambda findings for usages in enhanced for loops (#2518)
  • Fix bug where nested MissingBraces violations' suggested fixes result in broken code (#3797)
  • Add support for specifying exemptPrefixes/exemptNames for UnusedVariable via flags (#2753)
  • UnusedMethod: Added exempting variable annotations (#2881)

Full Changelog: google/error-prone@v2.21.1...v2.22.0

Commits
  • 7114c31 Release Error Prone 2.22.0
  • c94d74d Update release.yml - temporarily disable sonatype deployments
  • 080411e Added exempting variable annotations
  • 737dec0 Remove DiffNotApplicableException
  • f3a2bf8 Update ci.yml for JDK 21 release
  • 1d2bc93 Introduce ErrorProneFlags.get{Set,List}OrEmpty, because basically every cal...
  • 1bec842 Fix a crash in UnnecessaryAsync
  • d2ee28e Fix a crash in TimeUnitConversionChecker
  • ac424d0 Tighten the return types in Fix.
  • 58e5bb8 Update and wordsmith the @CompileTimeConstant documentation to reflect chan...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.21.1 to 2.22.0.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.21.1...v2.22.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #3393 (5cf01a0) into main (7f6944c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3393   +/-   ##
=========================================
  Coverage     64.24%   64.24%           
+ Complexity     3491     3489    -2     
=========================================
  Files           264      264           
  Lines         20157    20157           
  Branches       3365     3365           
=========================================
+ Hits          12949    12950    +1     
- Misses         5527     5530    +3     
+ Partials       1681     1677    -4     

see 3 files with indirect coverage changes

@willyborankin willyborankin added the backport 2.x backport to 2.x branch label Sep 25, 2023
@reta reta merged commit 826bdeb into main Sep 25, 2023
69 checks passed
@reta reta deleted the dependabot/gradle/com.google.errorprone-error_prone_annotations-2.22.0 branch September 25, 2023 11:38
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3393-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 826bdebc8c1c017868f5226191e9ff419e42642f
# Push it to GitHub
git push --set-upstream origin backport/backport-3393-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3393-to-2.x.

willyborankin added a commit to willyborankin/security that referenced this pull request Sep 25, 2023
…otations from 2.21.1 to 2.22.0

Backport 826bdeb from opensearch-project#3393

Signed-off-by: Andrey Pleskach <[email protected]>
reta pushed a commit to reta/security that referenced this pull request Sep 25, 2023
….21.1 to 2.22.0 (opensearch-project#3393)

Bumps
[com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone)
from 2.21.1 to 2.22.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/error-prone/releases">com.google.errorprone:error_prone_annotations's
releases</a>.</em></p>
<blockquote>
<h2>Error Prone 2.22.0</h2>
<p>We are considering raising the minimum supported JDK from JDK 11 to
JDK 17 in a future release of Error Prone, see <a
href="https://redirect.github.com/google/error-prone/issues/3803">#3803</a>.
Note that using a newer JDK version to run javac during the build
doesn't prevent building code that is deployed to earlier versions, for
example it's supported to use the JDK 17 javac and pass <code>--release
11</code> to compile Java 11 code that is deployed to a JDK 11 runtime.
If you have feedback, please comment on <a
href="https://redirect.github.com/google/error-prone/issues/3803">#3803</a>.</p>
<p>New checks:</p>
<ul>
<li><a
href="https://errorprone.info/bugpattern/ClosingStandardOutputStreams"><code>ClosingStandardOutputStreams</code></a>:
Prevents accidentally closing <code>System.{out,err}</code> with
try-with-resources</li>
<li><a
href="https://errorprone.info/bugpattern/TruthContainsExactlyElementsInUsage"><code>TruthContainsExactlyElementsInUsage</code></a>:
<code>containsExactly</code> is preferred over
<code>containsExactlyElementsIn</code> when creating new iterables</li>
<li><a
href="https://errorprone.info/bugpattern/UnnecessaryAsync"><code>UnnecessaryAsync</code></a>:
detects unnecessary use of async primitives in local (and hence
single-threaded) scopes</li>
<li><a
href="https://errorprone.info/bugpattern/ReturnAtTheEndOfVoidFunction"><code>ReturnAtTheEndOfVoidFunction</code></a>:
detects unnecessary <code>return</code> statements at the end of
<code>void</code> functions</li>
<li><a
href="https://errorprone.info/bugpattern/MultimapKeys"><code>MultimapKeys</code></a>:
Suggests using <code>keySet()</code> instead of iterating over
<code>Multimap.keys()</code>, which does not collapse duplicates</li>
</ul>
<p>Bug fixes and improvements:</p>
<ul>
<li>Don't complain about literal IP addresses in
<code>AddressSelection</code> (<a
href="https://github.com/google/error-prone/commit/44b65527debbc57892f21ca3ba458b16771e423e">https://github.com/google/error-prone/commit/44b65527debbc57892f21ca3ba458b16771e423e</a>)</li>
<li>Prevent SuggestedFixes#renameMethod from modifying return type
declaration (<a
href="https://redirect.github.com/google/error-prone/issues/4043">#4043</a>)</li>
<li>Fix UnusedVariable false positives for private record parameters (<a
href="https://redirect.github.com/google/error-prone/issues/2713">#2713</a>)</li>
<li>When running in conservative mode, no longer assume that
implementations of <code>Map.get</code>, etc. return <code>null</code>
(<a
href="https://redirect.github.com/google/error-prone/issues/2910">#2910</a>)</li>
<li>CanIgnoreReturnValueSuggester: Support additional exempting method
annotations (<a
href="https://redirect.github.com/google/error-prone/issues/4009">#4009</a>)</li>
<li>UnusedVariable: exclude junit5's <code>@RegisterExtension</code> (<a
href="https://redirect.github.com/google/error-prone/issues/3892">#3892</a>)</li>
<li>Support running all available patch checks (<a
href="https://redirect.github.com/google/error-prone/issues/947">#947</a>)</li>
<li>Upgrade java-diff-utils 4.0 -&gt; 4.12 (<a
href="https://redirect.github.com/google/error-prone/issues/4081">#4081</a>)</li>
<li>Flag unused Refaster template parameters (<a
href="https://redirect.github.com/google/error-prone/issues/4060">#4060</a>)</li>
<li>Support <code>@SuppressWarnings(&quot;all&quot;)</code> (<a
href="https://redirect.github.com/google/error-prone/issues/4065">#4065</a>)</li>
<li>Prevent Refaster <code>UMemberSelect</code> from matching method
parameters (<a
href="https://redirect.github.com/google/error-prone/issues/2456">#2456</a>)</li>
<li>MissingDefault : Don't require <code>// fall out</code> comments on
expression switches (<a
href="https://redirect.github.com/google/error-prone/issues/2709">#2709</a>)</li>
<li>Skip UnnecessaryLambda findings for usages in enhanced for loops (<a
href="https://redirect.github.com/google/error-prone/issues/2518">#2518</a>)</li>
<li>Fix bug where nested MissingBraces violations' suggested fixes
result in broken code (<a
href="https://redirect.github.com/google/error-prone/issues/3797">#3797</a>)</li>
<li>Add support for specifying
<code>exemptPrefixes</code>/<code>exemptNames</code> for UnusedVariable
via flags (<a
href="https://redirect.github.com/google/error-prone/issues/2753">#2753</a>)</li>
<li>UnusedMethod: Added exempting variable annotations (<a
href="https://redirect.github.com/google/error-prone/issues/2881">#2881</a>)</li>
</ul>
<p>Full Changelog: <a
href="https://github.com/google/error-prone/compare/v2.21.1...v2.22.0">https://github.com/google/error-prone/compare/v2.21.1...v2.22.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/google/error-prone/commit/7114c31a8819c5b5debd4506f7aca5fd4fe6bc15"><code>7114c31</code></a>
Release Error Prone 2.22.0</li>
<li><a
href="https://github.com/google/error-prone/commit/c94d74da01c750923eb51c9bfeb274ddacaea012"><code>c94d74d</code></a>
Update release.yml - temporarily disable sonatype deployments</li>
<li><a
href="https://github.com/google/error-prone/commit/080411ec38e78e8677afa61cbf3fd061b7923134"><code>080411e</code></a>
Added exempting variable annotations</li>
<li><a
href="https://github.com/google/error-prone/commit/737dec07570ae14f71c808281187adbb5cd947cb"><code>737dec0</code></a>
Remove DiffNotApplicableException</li>
<li><a
href="https://github.com/google/error-prone/commit/f3a2bf8ea5bf9687cb7a42ad25db01dfb96cb84e"><code>f3a2bf8</code></a>
Update ci.yml for JDK 21 release</li>
<li><a
href="https://github.com/google/error-prone/commit/1d2bc93bfab99cc08f96e9c4c534a829ece8da2b"><code>1d2bc93</code></a>
Introduce <code>ErrorProneFlags.get{Set,List}OrEmpty</code>, because
basically every cal...</li>
<li><a
href="https://github.com/google/error-prone/commit/1bec842493f2fabbb808e0d8f2074083df5b742f"><code>1bec842</code></a>
Fix a crash in UnnecessaryAsync</li>
<li><a
href="https://github.com/google/error-prone/commit/d2ee28e8576e5b23cb7538078e1b75484af9c15a"><code>d2ee28e</code></a>
Fix a crash in TimeUnitConversionChecker</li>
<li><a
href="https://github.com/google/error-prone/commit/ac424d0ce91c9ccb89be611f5e915d384df19d5b"><code>ac424d0</code></a>
Tighten the return types in Fix.</li>
<li><a
href="https://github.com/google/error-prone/commit/58e5bb8a3cf65b800102832d6fe65a55e46161c4"><code>58e5bb8</code></a>
Update and wordsmith the <code>@CompileTimeConstant</code> documentation
to reflect chan...</li>
<li>Additional commits viewable in <a
href="https://github.com/google/error-prone/compare/v2.21.1...v2.22.0">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.google.errorprone:error_prone_annotations&package-manager=gradle&previous-version=2.21.1&new-version=2.22.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 826bdeb)
peternied pushed a commit that referenced this pull request Sep 25, 2023
…otations from 2.21.1 to 2.22.0 (#3400)

Backport
826bdeb
from #3393

Signed-off-by: Andrey Pleskach <[email protected]>
DarshitChanpura pushed a commit to DarshitChanpura/security that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants