Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Retry code coverage upload on failure (#3242) #3243

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

peternied
Copy link
Member

Description

Backport of d7d7f62 from #3242

Signed-off-by: Peter Nied [email protected]
(cherry picked from commit d7d7f62)

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Backport of d7d7f62 from #3242

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit d7d7f62)
@peternied peternied force-pushed the backport/backport-3242-to-2.x branch from 6e92a76 to d00d774 Compare August 26, 2023 21:47
@@ -55,10 +55,15 @@ jobs:
-x test

- name: Coverage
uses: codecov/codecov-action@v1
uses: Wandalen/wretry.action@v1.3.0
Copy link
Member Author

@peternied peternied Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually backported because the codecov version was incremented in a change v1->v3 was not backported

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #3243 (6e92a76) into 2.x (d0544cf) will increase coverage by 0.20%.
The diff coverage is n/a.

❗ Current head 6e92a76 differs from pull request most recent head d00d774. Consider uploading reports for the commit d00d774 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3243      +/-   ##
============================================
+ Coverage     62.36%   62.57%   +0.20%     
- Complexity     3294     3387      +93     
============================================
  Files           252      252              
  Lines         19456    19456              
  Branches       3308     3308              
============================================
+ Hits          12134    12174      +40     
+ Misses         5705     5692      -13     
+ Partials       1617     1590      -27     

see 20 files with indirect coverage changes

@DarshitChanpura DarshitChanpura merged commit d0a89f7 into 2.x Aug 27, 2023
@DarshitChanpura DarshitChanpura deleted the backport/backport-3242-to-2.x branch August 27, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants