Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry code coverage upload on failure #3242

Merged

Conversation

peternied
Copy link
Member

Description

Noticed in several results of
https://github.com/opensearch-project/security/actions/runs/5978371801/job/16220344142?pr=3123 that the code coverage upload had failed silently, and the annotations make it look like many tests were not executed. Since in this job there were 9 failures at the same time, adding retry mechanism as well to prevent blind restarting of workflows.

Additional background

Solution sourced from this stackoverflow question "How to automatically retry github action jobs on failure?" [1]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Noticed in several results of
https://github.com/opensearch-project/security/actions/runs/5978371801/job/16220344142?pr=3123
that the code coverage upload had failed silently, and the annotations
make it look like many tests were not executed.  Since in this job there
were 9 failures at the same time, adding retry mechanism as well to
prevent blind restarting of workflows.

Signed-off-by: Peter Nied <[email protected]>
@peternied peternied force-pushed the retry-uploading-coverage-data branch from aad739e to ea73034 Compare August 25, 2023 19:08
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #3242 (ea73034) into main (ed61646) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3242      +/-   ##
============================================
- Coverage     62.51%   62.51%   -0.01%     
+ Complexity     3353     3351       -2     
============================================
  Files           254      254              
  Lines         19732    19732              
  Branches       3334     3334              
============================================
- Hits          12336    12335       -1     
- Misses         5767     5769       +2     
+ Partials       1629     1628       -1     

see 3 files with indirect coverage changes

@willyborankin willyborankin merged commit d7d7f62 into opensearch-project:main Aug 25, 2023
@peternied peternied added the backport 2.x backport to 2.x branch label Aug 26, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3242-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d7d7f626042a42626bacd25de4af178b8dc37e18
# Push it to GitHub
git push --set-upstream origin backport/backport-3242-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3242-to-2.x.

@peternied peternied deleted the retry-uploading-coverage-data branch August 26, 2023 20:56
peternied added a commit that referenced this pull request Aug 26, 2023
Backport of d7d7f62 from #3242

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit d7d7f62)
peternied added a commit that referenced this pull request Aug 26, 2023
Backport of d7d7f62 from #3242

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit d7d7f62)
DarshitChanpura pushed a commit that referenced this pull request Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants