Make invalid password message clearer

[derek-ho]

Description

Returns the error message instead of the validation message because validation message should already have been shown in above case statements.

Issues Resolved

Fix: #3055

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Merging #3057 (16be66f) into main (bd084c8) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main    #3057      +/-   ##
============================================
- Coverage     62.46%   62.44%   -0.02%     
+ Complexity     3354     3352       -2     
============================================
  Files           254      254              
  Lines         19749    19747       -2     
  Branches       3334     3334              
============================================
- Hits          12337    12332       -5     
+ Misses         5784     5783       -1     
- Partials       1628     1632       +4     

Files Changed	Coverage Δ
...curity/dlic/rest/validation/PasswordValidator.java	82.53% <66.66%> (ø)
.../dlic/rest/validation/RequestContentValidator.java	91.61% <100.00%> (-0.10%)	⬇️

... and 6 files with indirect coverage changes

[willyborankin]

Checkstyle fails :-). gradle checkstyleMain checkstyleTest should help

[willyborankin]

I think test failures are not related to this change.

[peternied]

I think the previous behavior was better for users to act on, why remove the distinct message?

[peternied]

CI failures due to broken tests

[peternied]

Thanks for cleaning up that code, this makes the documentation align better to how the product behaves.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3057-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 847f91108a4a10c8368fde26a8f79266edf423c3
# Push it to GitHub
git push --set-upstream origin backport/backport-3057-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3057-to-2.x.

[DarshitChanpura]

@derek-ho Mind creating the backport manually?