Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Create user API giving misleading error messages #3055

Closed
derek-ho opened this issue Jul 26, 2023 · 2 comments · Fixed by #3057
Closed

[BUG] Create user API giving misleading error messages #3055

derek-ho opened this issue Jul 26, 2023 · 2 comments · Fixed by #3057
Assignees
@derek-ho
Labels
bug Something isn't working

Comments

@derek-ho
Copy link
Collaborator

Reproduce:

  • with password validation message, even if password passes validation, and create user is only getting rejected due to weak password it is still showing the password validation error message, which can be frustrating
@derek-ho derek-ho added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 26, 2023
@derek-ho derek-ho self-assigned this Jul 26, 2023
@derek-ho derek-ho mentioned this issue Jul 26, 2023
Merged
3 tasks
@stephen-crawford
Copy link
Contributor

[Triage] Hi @derek-ho, can you provide further details about the messages you expect vs what you are receiving? Thank you.

@stephen-crawford stephen-crawford removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Jul 31, 2023
@stephen-crawford
Copy link
Contributor

[Triage] @derek-ho just following-up.

cwperks added a commit that referenced this issue Aug 17, 2023
@derek-ho @cwperks
Change password security message (#3057)
847f911 
### Description
Returns the error message instead of the validation message because
validation message should already have been shown in above case
statements.

### Issues Resolved
Fix: #3055 

Is this a backport? If so, please add backport PR # and/or commits #

### Testing
[Please provide details of testing done: unit testing, integration
testing and manual testing]

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
derek-ho added a commit to derek-ho/security that referenced this issue Aug 17, 2023
@derek-ho
Change password security message (opensearch-project#3057)
648d737 
Returns the error message instead of the validation message because
validation message should already have been shown in above case
statements.

Fix: opensearch-project#3055

Is this a backport? If so, please add backport PR # and/or commits #

[Please provide details of testing done: unit testing, integration
testing and manual testing]

- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
(cherry picked from commit 847f911)
@derek-ho derek-ho mentioned this issue Aug 17, 2023
Merged
@davidlago davidlago mentioned this issue Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derek-ho derek-ho

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make invalid password message clearer derek-ho/security
2 participants
@derek-ho @stephen-crawford