Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action indices:admin/index_template/* to cluster_manage_index_tem… #2409

Merged

Conversation

srt
Copy link
Contributor

@srt srt commented Jan 17, 2023

…plates (#2407)

Signed-off-by: Stefan Reuter [email protected]

Description

Adds permissions to manage composable templates to the default action group cluster_manage_index_templates.

Issues Resolved

#2407

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@srt srt requested a review from a team January 17, 2023 21:04
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srt Thanks for the contribution, I just started the CI workflow and myself and other maintainers will review your change in detail.

cwperks
cwperks previously approved these changes Jan 19, 2023
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how cluster:admin/component_template fits into this space, it seems like it could be related [1], what do you think about including it as well?

@DarshitChanpura
Copy link
Member

I agree with @peternied 's comments above. As _component_templates can be used to compose an index template, it might be a good step to include that action here.

@srt
Copy link
Contributor Author

srt commented Jan 19, 2023

Good point, I have added cluster:admin/component_template/*

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peternied peternied added the backport 2.x backport to 2.x branch label Jan 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #2409 (c67b8a4) into main (9cdaeca) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2409      +/-   ##
============================================
- Coverage     61.11%   61.01%   -0.11%     
+ Complexity     3273     3268       -5     
============================================
  Files           260      260              
  Lines         18362    18362              
  Branches       3249     3249              
============================================
- Hits          11222    11203      -19     
- Misses         5555     5570      +15     
- Partials       1585     1589       +4     
Impacted Files Coverage Δ
...org/opensearch/security/rest/TenantInfoAction.java 77.94% <0.00%> (-10.30%) ⬇️
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.36% <0.00%> (-4.31%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
...ecurity/configuration/ConfigurationRepository.java 72.13% <0.00%> (-2.19%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied peternied merged commit e4b7361 into opensearch-project:main Jan 20, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 20, 2023
#2409)

* Add actions cluster:admin/component_template/* to cluster_manage_index_templates

Signed-off-by: Stefan Reuter <[email protected]>
(cherry picked from commit e4b7361)
@srt srt deleted the fix-index-templates-action-group branch January 20, 2023 14:23
RyanL1997 pushed a commit that referenced this pull request Jan 20, 2023
#2409) (#2412)

* Add actions cluster:admin/component_template/* to cluster_manage_index_templates

Signed-off-by: Stefan Reuter <[email protected]>
(cherry picked from commit e4b7361)
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
opensearch-project#2409) (opensearch-project#2412)

* Add actions cluster:admin/component_template/* to cluster_manage_index_templates

Signed-off-by: Stefan Reuter <[email protected]>
(cherry picked from commit e4b7361)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants