Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Default action group cluster_manage_index_templates should include permissions for composable index templates #2407

Closed
srt opened this issue Jan 14, 2023 · 2 comments
Closed

[BUG] Default action group cluster_manage_index_templates should include permissions for composable index templates #2407

srt opened this issue Jan 14, 2023 · 2 comments
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@srt
Copy link
Contributor

srt commented Jan 14, 2023

What is the bug?
The default action group cluster_manage_index_templates currently only contains the permission indices:admin/template/* for legacy templates. It should also include indices:admin/index_template/* to support composable templates.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Create a role with cluster_permissions set to cluster_manage_index_templates
  2. Create a user with that role
  3. Send a PutIndexTemplateRequest to OpenSearch
  4. See error [security_exception] no permissions for [indices:admin/index_template/put]

What is the expected behavior?
Composable templates can be managed by users with cluster_manage_index_templates permission.

What is your host/environment?

  • 2.4.1
@srt srt added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 14, 2023
@stephen-crawford stephen-crawford added enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jan 17, 2023
@stephen-crawford
Copy link
Contributor

[Triage] @scrawfor99 please follow up and add additional notes on the issue stating what additional actions it permits.

@srt, if you would like to contribute to the codebase I would encourage you to take a moment to address the change in a PR to this file. Thank you!

srt added a commit to srt/opensearch-security that referenced this issue Jan 17, 2023
@srt
Add action indices:admin/index_template/* to cluster_manage_index_tem…
910edcb 
…plates (opensearch-project#2407)
srt added a commit to srt/opensearch-security that referenced this issue Jan 17, 2023
@srt
Add action indices:admin/index_template/* to cluster_manage_index_tem…
1a875f5 
…plates (opensearch-project#2407)

Signed-off-by: Stefan Reuter <[email protected]>
@srt srt mentioned this issue Jan 17, 2023
Merged
3 tasks
@cwperks
Copy link
Member

cwperks commented Jan 23, 2023

Closing this issue as #2409 was merged.

@cwperks cwperks closed this as completed Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srt @cwperks @stephen-crawford