Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds build script for publishing plugin zip #1921

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Jun 28, 2022

Description

Adds build script for publishing plugin zips to maven repo.

  • Category : Maintenance
  • Required as part of 2.1 release

Issues

Check List

- [ ] New functionality includes testing
- [ ] New functionality has been documented

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura DarshitChanpura requested a review from a team June 28, 2022 20:24
@peternied peternied added the backport 2.x backport to 2.x branch label Jun 28, 2022
prudhvigodithi
prudhvigodithi previously approved these changes Jun 28, 2022
cliu123
cliu123 previously approved these changes Jun 28, 2022
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to modify the script to be executable https://stackoverflow.com/a/40979016/533057

@DarshitChanpura
Copy link
Member Author

You need to modify the script to be executable https://stackoverflow.com/a/40979016/533057

Done. Thank you for pointing this out @peternied !

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a little bit of offline debugging, git add --chmod=+x {file} is the easiest way to go. Just checked the latest version, looks good to me

@cliu123
Copy link
Member

cliu123 commented Jun 28, 2022

@DarshitChanpura Please merge the PR when it's ready.

@peternied peternied merged commit 192ef35 into opensearch-project:main Jun 28, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 28, 2022
DarshitChanpura added a commit that referenced this pull request Jun 29, 2022
stephen-crawford pushed a commit to stephen-crawford/security that referenced this pull request Nov 10, 2022
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add build script to scripts folder
4 participants