Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build script to scripts folder #1922

Closed
DarshitChanpura opened this issue Jun 28, 2022 · 2 comments · Fixed by #1921
Closed

Add build script to scripts folder #1922

DarshitChanpura opened this issue Jun 28, 2022 · 2 comments · Fixed by #1921
Assignees
Labels

Comments

@DarshitChanpura
Copy link
Member

Security is missing build.sh under scripts folder which is preventing it from getting published to maven.

@DarshitChanpura
Copy link
Member Author

@prudhvigodithi Can you please review this PR? Also, a couple of questions:

How do we test this?
How do we make sure that we didn't break something in future?

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jun 28, 2022

Hey @DarshitChanpura you can leverage the existing build flow.
For this PR I have executed
./build.sh manifests/2.1.0/opensearch-2.1.0.yml --snapshot --component security

With manifest entry as

  - name: security
    repository: https://github.com/DarshitChanpura/security.git
    ref: zip-build-script

Log shows the build script being called from security/scripts/build.sh

Executing "bash /tmp/tmpnmgagmmy/security/scripts/build.sh -v 2.1.0 -p linux -a x64 -s true -o builds" in /tmp/tmpnmgagmmy/security
+ getopts :h:v:q:s:o:p:a: arg

Inside Output folder I can see the zips.

ls -ltr tar/builds/opensearch/maven/org/opensearch/plugin/opensearch-security/2.1.0.0-SNAPSHOT/
total 40332
-rw-rw-r-- 1 opensearch opensearch       32 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.zip.md5
-rw-rw-r-- 1 opensearch opensearch       32 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.pom.md5
-rw-rw-r-- 1 opensearch opensearch      128 Jun 28 20:36 maven-metadata.xml.sha512
-rw-rw-r-- 1 opensearch opensearch       64 Jun 28 20:36 maven-metadata.xml.sha256
-rw-rw-r-- 1 opensearch opensearch       40 Jun 28 20:36 maven-metadata.xml.sha1
-rw-rw-r-- 1 opensearch opensearch      128 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.zip.sha512
-rw-rw-r-- 1 opensearch opensearch       64 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.zip.sha256
-rw-rw-r-- 1 opensearch opensearch      128 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.pom.sha512
-rw-rw-r-- 1 opensearch opensearch       64 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.pom.sha256
-rw-rw-r-- 1 opensearch opensearch       40 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.pom.sha1
-rw-rw-r-- 1 opensearch opensearch     1039 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.pom
-rw-rw-r-- 1 opensearch opensearch       40 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.zip.sha1
-rw-rw-r-- 1 opensearch opensearch 41240949 Jun 28 20:36 opensearch-security-2.1.0.0-20220628.203623-1.zip
-rw-rw-r-- 1 opensearch opensearch       32 Jun 28 20:36 maven-metadata.xml.md5
-rw-rw-r-- 1 opensearch opensearch      796 Jun 28 20:36 maven-metadata.xml

@peterzhuamazon @bbarani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants