Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement end-to-end testing of the new named routes API and ensure backwards compatibility. #2928

Closed
3 tasks done
Tracked by #2590
peternied opened this issue Jul 3, 2023 · 3 comments · Fixed by #3226
Closed
3 tasks done
Tracked by #2590

Implement end-to-end testing of the new named routes API and ensure backwards compatibility. #2928

peternied opened this issue Jul 3, 2023 · 3 comments · Fixed by #3226
Assignees
@DarshitChanpura
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@peternied
Copy link
Member

peternied commented Jul 3, 2023 •
edited by DarshitChanpura
Loading

Should have the following if not more test cases:

  • Allows authorized user to access to AuthZ in REST permissioned API
  • Denies unauthorized user to access to AuthZ in REST permissioned API
  • Denies unauthenticated user access to AuthZ in REST permissioned API

Each of these tests should confirm:

  • response code
  • response body
  • message saved to the audit log
  • message saved to the error log
@peternied peternied mentioned this issue Jul 3, 2023
Closed
15 tasks
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Jul 3, 2023
@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 10, 2023
@stephen-crawford
Copy link
Contributor

[Triage] Thank you for detailing this information @peternied. Assigning to @DarshitChanpura as he is driving this feature.

@peternied
Copy link
Member Author

@DarshitChanpura DarshitChanpura mentioned this issue Aug 16, 2023
Merged
3 tasks
@DarshitChanpura
Copy link
Member

DarshitChanpura commented Aug 18, 2023 •
edited by peternied
Loading

Note: this is a two part effort.

This was referenced Aug 21, 2023
Merged
Closed
stephen-crawford pushed a commit that referenced this issue Aug 24, 2023
@DarshitChanpura
Implements end-to-end integration tests for Authorization in Rest Lay…
9a7e517 
…er (#3226)

### Description
This change test Authorization in Rest Layer feature by testing
NamedRoutes and legacy Routes. It does so by adding two plugins in
security plugin's test framework with one registering NamedRoutes and
other registering legacy Routes.

* Category: Enhancement


### Issues Resolved
- Resolves #2928 


### Testing
Integration tests

### Check List
- [x] New functionality includes testing
- [x] New functionality has been documented
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarshitChanpura DarshitChanpura

Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements end-to-end integration tests for Authorization in Rest Layer DarshitChanpura/security
4 participants
@peternied @davidlago @DarshitChanpura @stephen-crawford