-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a test to check similarity between audit logs generated from REST layer and TRANSPORT layer #3192
Adds a test to check similarity between audit logs generated from REST layer and TRANSPORT layer #3192
Conversation
…T layer and TRANSPORT layer Signed-off-by: Darshit Chanpura <[email protected]>
bc5bebb
to
f1e0f4a
Compare
Codecov Report
@@ Coverage Diff @@
## main #3192 +/- ##
=========================================
Coverage 62.45% 62.45%
+ Complexity 3353 3352 -1
=========================================
Files 254 254
Lines 19748 19748
Branches 3334 3334
=========================================
Hits 12334 12334
Misses 5785 5785
Partials 1629 1629 |
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
8c5adfb
to
56586f8
Compare
…message for each of REST and Transport layer Signed-off-by: Darshit Chanpura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for drilling in on these scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DarshitChanpura, thanks for adding the tests. This is looking good to me, and I just left some minor questions for my understanding.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3192-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b0e3cdcdd7edae90beab5f8c882e5f3fdf25cea7
# Push it to GitHub
git push --set-upstream origin backport/backport-3192-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
Backport is currently blocked by #3230 |
@DarshitChanpura Can you attach this to the pull request that will incorporate all of the AuthZ in the Rest layer changes into the 2.x branch? |
Issues Resolved
Testing
Integration testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.