Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test to check similarity between audit logs generated from REST layer and TRANSPORT layer #3192

Conversation

DarshitChanpura
Copy link
Member

Issues Resolved

Testing

Integration testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…T layer and TRANSPORT layer

Signed-off-by: Darshit Chanpura <[email protected]>
@DarshitChanpura DarshitChanpura force-pushed the auditlog-similarity-rest-transport branch from bc5bebb to f1e0f4a Compare August 16, 2023 13:52
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #3192 (ffdef97) into main (32d3112) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3192   +/-   ##
=========================================
  Coverage     62.45%   62.45%           
+ Complexity     3353     3352    -1     
=========================================
  Files           254      254           
  Lines         19748    19748           
  Branches       3334     3334           
=========================================
  Hits          12334    12334           
  Misses         5785     5785           
  Partials       1629     1629           

Signed-off-by: Darshit Chanpura <[email protected]>
@DarshitChanpura DarshitChanpura force-pushed the auditlog-similarity-rest-transport branch from 8c5adfb to 56586f8 Compare August 16, 2023 21:17
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for drilling in on these scenarios.

Copy link
Collaborator

@RyanL1997 RyanL1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DarshitChanpura, thanks for adding the tests. This is looking good to me, and I just left some minor questions for my understanding.

@DarshitChanpura DarshitChanpura merged commit b0e3cdc into opensearch-project:main Aug 21, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3192-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b0e3cdcdd7edae90beab5f8c882e5f3fdf25cea7
# Push it to GitHub
git push --set-upstream origin backport/backport-3192-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3192-to-2.x.

@DarshitChanpura
Copy link
Member Author

Backport is currently blocked by #3230

@peternied peternied removed the backport 2.x backport to 2.x branch label Aug 31, 2023
@peternied
Copy link
Member

@DarshitChanpura Can you attach this to the pull request that will incorporate all of the AuthZ in the Rest layer changes into the 2.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authorization in rest layer automated test for audit logging
4 participants