Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Migrate modern build.gradle into 1.x branches #2535

Closed
peternied opened this issue Mar 8, 2023 · 4 comments
Closed

[BUG] Migrate modern build.gradle into 1.x branches #2535

peternied opened this issue Mar 8, 2023 · 4 comments
Labels
bug Something isn't working help wanted Community contributions are especially encouraged for these issues. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@peternied
Copy link
Member

Background

There are many features of OpenSearch and its related ecosystem of tools that are java code as well as gradle plugins. When security was initially [migrated to gradle] the connection to gradle plugins provided by OpenSearch were not included.

After mounting issues such as aligning transitive dependency versions [1], publishing plugin zip files [2], and running OpenSearch's integration tests[3], a [second gradle migration] was performed. This build change was involved.

The security plugin codebase is running this second iteration on its main branches, in addition to the 2.X, and 2.1+ branches.

Problem

1.x and 1.3 branches are using the first iteration of the gradle build, leaving many features are locked away from being backported.

Blocked features backports

Related Issues

@peternied peternied added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Mar 8, 2023
@peternied
Copy link
Member Author

@opensearch-project/security Our list of blocked features is only getting longer and its preventing us from following best practices in one of our primarily maintained branches 1.3. According to the release schedule we will at least maintain 1.3 until December 31, 2023. But that window could be extended.

On the difficulty of this work, working on gradle is not often a task we perform, but its relatively simple once in the space with structured example of how the 2.1 migration occurred. It would require gumption, but I think even first time contributors could take this on.

@DarshitChanpura
Copy link
Member

Our list of blocked features is only getting longer and its preventing us from following best practices in one of our primarily maintained branches 1.3

Agreed and agreed. Should we take this as a high priority task and update the gradle to second iteration on 1.3 to unblock feature backporting?

@peternied peternied added the help wanted Community contributions are especially encouraged for these issues. label Mar 9, 2023
@peternied peternied transferred this issue from opensearch-project/security-dashboards-plugin Mar 9, 2023
@peternied
Copy link
Member Author

Opened this issue in the wrong repo - but it impacts security dashboard plugin too

@DarshitChanpura DarshitChanpura changed the title [BUG] Migrate modern gradle.build into 1.x branches [BUG] Migrate modern build.gradle into 1.x branches Mar 9, 2023
@peternied peternied added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Mar 13, 2023
@cwperks
Copy link
Member

cwperks commented Mar 20, 2024

Closing this issue. The changes to build.gradle will not be backported to the 1.x branches.

@cwperks cwperks closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Community contributions are especially encouraged for these issues. triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

3 participants