Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Switch to maven to download plugin snapshots #1351

Closed
wants to merge 4 commits into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a039441 from #1331

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit a039441)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team February 28, 2023 02:19
@peternied
Copy link
Member

We haven't published a 1.3 build to maven... looking into what that will take

@peternied peternied self-assigned this Feb 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Merging #1351 (1514f72) into 1.3 (37748d7) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              1.3    opensearch-project/security-dashboards-plugin#1351   +/-   ##
=======================================
  Coverage   72.33%   72.33%           
=======================================
  Files          88       88           
  Lines        1916     1916           
  Branches      245      245           
=======================================
  Hits         1386     1386           
  Misses        474      474           
  Partials       56       56           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied
Copy link
Member

This issue is blocked on the security plugin supporting publishing maven builds. I've created an issue to track supporting this, I'd love to know what y'all think

- run: |
mvn dependency:get \
-DremoteRepositories=https://aws.oss.sonatype.org/content/repositories/snapshots/ \
-Dartifact=org.opensearch.plugin:${{ inputs.plugin-name }}:${{ inputs.plugin-version }}-SNAPSHOT:zip \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-SNAPSHOT should be removed here and should be passed dynamically in the plugin-version variable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository only storage snapshots, -D remoteRepositories=https://aws.oss.sonatype.org/content/repositories/snapshots/

@peternied
Copy link
Member

This isn't actively being worked on, the bug associated with this is still active, and this could be unblocked if when that is resolved.

@peternied peternied closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants