-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 1.3] Switch to maven to download plugin snapshots #1351
Conversation
Signed-off-by: Peter Nied <[email protected]> (cherry picked from commit a039441)
We haven't published a 1.3 build to maven... looking into what that will take |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 1.3 opensearch-project/security-dashboards-plugin#1351 +/- ##
=======================================
Coverage 72.33% 72.33%
=======================================
Files 88 88
Lines 1916 1916
Branches 245 245
=======================================
Hits 1386 1386
Misses 474 474
Partials 56 56 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This issue is blocked on the security plugin supporting publishing maven builds. I've created an issue to track supporting this, I'd love to know what y'all think |
- run: | | ||
mvn dependency:get \ | ||
-DremoteRepositories=https://aws.oss.sonatype.org/content/repositories/snapshots/ \ | ||
-Dartifact=org.opensearch.plugin:${{ inputs.plugin-name }}:${{ inputs.plugin-version }}-SNAPSHOT:zip \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-SNAPSHOT
should be removed here and should be passed dynamically in the plugin-version
variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository only storage snapshots, -D remoteRepositories=https://aws.oss.sonatype.org/content/repositories/snapshots/
This isn't actively being worked on, the bug associated with this is still active, and this could be unblocked if when that is resolved. |
Backport a039441 from #1331