Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] jackson dependencies should be synchronized with OpenSearch #1816

Closed
peternied opened this issue May 2, 2022 · 4 comments · Fixed by #1888
Closed

[Bug] jackson dependencies should be synchronized with OpenSearch #1816

peternied opened this issue May 2, 2022 · 4 comments · Fixed by #1888
Labels
bug Something isn't working

Comments

@peternied
Copy link
Member

This is the second time we've had a distribution build break because both OpenSearch and security plugin have imported different versions of the jackson libraries. We need a way to make sure the correct dependencies are in the security plugin and those dependencies will not create conflicts with OpenSearch.

@peternied peternied added the bug Something isn't working label May 2, 2022
@peternied peternied changed the title [Bug] jackson dependancies should be transitively imported [Bug] jackson dependencies should be synchronized with OpenSearch May 2, 2022
@reta
Copy link
Collaborator

reta commented May 2, 2022

@peternied the problem at large is that security plugin does not rely on opensearch.opensearchplugin (like in template [1] fe) so it is not possible to benefit from the shared versions using:

"implementation 'com.fasterxml.jackson.core:jackson-databind:${versions.jackson_databind}"

Do you by any chance know why the opensearch.opensearchplugin is skipped over?

[1] https://github.com/opensearch-project/opensearch-plugin-template-java/blob/main/build.gradle

@cliu123
Copy link
Member

cliu123 commented May 2, 2022

@reta Security plugin migrated the build system from Maven to Gradle, but still does not use pensearch.opensearchplugin as of now.

@reta
Copy link
Collaborator

reta commented May 2, 2022

Thanks @peternied , should we repurpose this issue to use opensearch.opensearchplugin in security instead of patching versions?

@peternied
Copy link
Member Author

@reta Lets close this issue, and I'll use the follow up in security to prevent a 3rd incident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants