Fix broken nextUrl= parameter logic
#940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
force-pushed
the
fix-next-url
branch
from
119420b to
3596ebb
Compare
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 87 87
Lines 1906 1906
Branches 242 242
=======================================
Hits 1375 1375
Misses 477 477
Partials 54 54 Continue to review full report at Codecov.
|
|
Removing the label for 2.0.0 as the PR hasn't been ready yet. |
|
Nice! I have just created an issue for this: #951. This is blocking tests from succeeding in 2.0 I think it should be prioritized or block 2.0.0 since I can imagine a lot of people getting this issue and the application would seem unusable. |
cliu123
force-pushed
the
fix-next-url
branch
2 times, most recently
from
168126d to
cd79940
Compare
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
fix-next-url
branch
2 times, most recently
from
071fdce to
562213f
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
fix-next-url
branch
from
562213f to
5d0afb9
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
fix-next-url
branch
from
5d0afb9 to
7e90a7b
Compare
kavilla
approved these changes
Apr 19, 2022
DarshitChanpura
approved these changes
Apr 19, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The nextUrl logic was getting back urls that looked like
%2Fgotundefinedit seems like with the recent node version change there were some breaking changes in the url parsing/processing systems. I've cleaned up the pattern and confirmed the behavior is correct with new integration tests.Category
Bug fix
Issues Resolved
.query#936Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.