Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of legacy url API .query #936

Closed
peternied opened this issue Apr 7, 2022 · 2 comments · Fixed by #940
Closed

Remove usage of legacy url API .query #936

peternied opened this issue Apr 7, 2022 · 2 comments · Fixed by #940
Labels
bug Something isn't working

Comments

@peternied
Copy link
Member

We should switch to .search which is part of the node api, see https://nodejs.org/docs/latest-v14.x/api/url.html which has more details.

Impacted code

const requestQuery = request.url.query as ParsedUrlQueryParams;
if (requestQuery.nextUrl !== undefined) {

@peternied peternied added the bug Something isn't working label Apr 7, 2022
@peternied
Copy link
Member Author

[Triage] We should also look into url.path that is used right above this location in the file.

@cliu123
Copy link
Member

cliu123 commented Apr 15, 2022

Removing the label for 2.0.0 as the PR hasn't been ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants