-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nextUrl for OpenID Authentication #1563
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
+ Coverage 67.06% 67.09% +0.02%
==========================================
Files 94 94
Lines 2402 2404 +2
Branches 318 323 +5
==========================================
+ Hits 1611 1613 +2
Misses 713 713
Partials 78 78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwperks Are you still working on this? Do you need extra hands to get this through?
It will be picked back up once #1579 is merged |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
@RyanL1997 @derek-ho @DarshitChanpura This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cwperks, thanks for putting this up, and I just left some comments.
Btw I think we need to update the branch with the latest changes |
Signed-off-by: Craig Perkins <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1563-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6374198119fcb2b33343460a3d2fdfcb44794f30
# Push it to GitHub
git push --set-upstream origin backport/backport-1563-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
I'll open up a manual backport for this. |
The backport for this is blocked by the backport for: #1579 |
Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 6374198)
Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 6374198) Co-authored-by: Craig Perkins <[email protected]>
Description
Adds support for
nextUrl
in OpenID Authentication. This change also supportsnextUrl
for multi authentication.If a user's session times out, they will resume where they previously left off instead of being directed back to the home page.
This change is modeled off of similar work done for SAML:
Related PRs:
Category
Enhancement
Issues Resolved
#1141
Testing
Tested using a keycloak IdP in local development. Opening this PR up as a draft as functional tests are written for this change to verify the new behavior.
I'm pushing the function test repo to update to Cypress12 which has official support for cross-origin testing: opensearch-project/opensearch-dashboards-functional-test#801
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.