Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Upgrade to Cypress12 #801

Open
cwperks opened this issue Aug 24, 2023 · 4 comments
Open

[META] Upgrade to Cypress12 #801

cwperks opened this issue Aug 24, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@cwperks
Copy link
Member

cwperks commented Aug 24, 2023

The opensearch-dashboards-functional-test repo is using an outdated version of Cypress (9.5.4). The current released version of cypress is 12.17.x which contains many useful improvements including support for cross-origin testing. A full changelog can be found here.

A feature branch (feature/cypress12) has been created for dashboards plugin repos to ensure that their tests run with the upgraded version of Cypress.

I am filing a META issue to track the issues filed in each dashboards plugin repo to ensure that their tests can run with Cypress12.

Sample PR from Security updating tests to remove usages of cy.server(): #800

Migration guide: https://docs.cypress.io/guides/references/migration-guide

Previously filed issue: #408

Dashboards and dashboards plugin issues:

@cwperks cwperks added enhancement New feature or request untriaged labels Aug 24, 2023
@SuZhou-Joe
Copy link
Member

Actually now cypress 9.5.4 has an issue that it will hang the test when running out of memory, and lacks many of the security fix.

@kavilla
Copy link
Member

kavilla commented Apr 2, 2024

I +1 this. There is improvements to performance, and could save our CI time and money.

OSD also takes a dependency on Cypress 9. So we should bump as well.

Tracked here: opensearch-project/OpenSearch-Dashboards#6309

cc: @manasvinibs

@zhongnansu
Copy link
Member

zhongnansu commented Jun 3, 2024

@peterzhuamazon @cwperks @kavilla @SuZhou-Joe Hi team, I wonder what's the progress to upgrade functional test repo to use cypress 12, is it still on track? Do we have a target release?

Linked the original issue created back in 2022 #408

cc: @seraphjiang @zengyan-amazon @BionIT

@d-rowe
Copy link
Member

d-rowe commented Nov 27, 2024

Hi @cwperks, I'm working on updating the main OSD repo to Cypress v12 (initial PR) with the goal of getting all of our consumers to an updated and unified version.

I'll post updates here as we make progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants