Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize all permissions from latest OpenSearch #1333

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

peternied
Copy link
Member

Description

We've noticed there are some permissions in OpenSearch that are not included in the UX dropdown of the security-dashboards-plugin

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We've noticed there are some permissions in OpenSearch that are not included in the UX dropdown of the security-dashboards-plugin

Signed-off-by: Peter Nied <[email protected]>
@peternied peternied requested a review from a team February 16, 2023 21:04
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d5441b2). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage        ?   71.78%           
=======================================
  Files           ?       88           
  Lines           ?     2027           
  Branches        ?      269           
=======================================
  Hits            ?     1455           
  Misses          ?      509           
  Partials        ?       63           
Impacted Files Coverage Δ
public/apps/configuration/constants.tsx 85.71% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RyanL1997 RyanL1997 merged commit e5c0588 into opensearch-project:main Feb 20, 2023
@peternied peternied deleted the all-permissions branch February 21, 2023 02:06
@cwperks cwperks added the backport 2.x backport to 2.x branch label Feb 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
We've noticed there are some permissions in OpenSearch that are not included in the UX dropdown of the security-dashboards-plugin

Signed-off-by: Peter Nied <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
(cherry picked from commit e5c0588)
RyanL1997 pushed a commit that referenced this pull request Feb 22, 2023
We've noticed there are some permissions in OpenSearch that are not included in the UX dropdown of the security-dashboards-plugin

Signed-off-by: Peter Nied <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
(cherry picked from commit e5c0588)
@cwperks
Copy link
Member

cwperks commented Feb 27, 2023

The documentation site for permissions should also be updated for this change so that all of these actions are reflected on the documentation website: https://opensearch.org/docs/latest/security/access-control/permissions/

I will follow-up with a PR to the documentation website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants