Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] fix null query filter conversion from sigma to query string query #813

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a59a014 from #722

* fix null query filter conversion from sigma to query string query

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix rule to query conversion tests for null filter

Signed-off-by: Surya Sashank Nistala <[email protected]>

* enhance test to verify non null doc doesnt match null query

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit a59a014)
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8990aed) 24.83% compared to head (9e47ea3) 24.83%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #813   +/-   ##
=========================================
  Coverage     24.83%   24.83%           
  Complexity     1024     1024           
=========================================
  Files           277      277           
  Lines         12683    12683           
  Branches       1389     1389           
=========================================
  Hits           3150     3150           
  Misses         9267     9267           
  Partials        266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon merged commit 658c2a3 into 2.x Feb 6, 2024
13 of 18 checks passed
@github-actions github-actions bot deleted the backport/backport-722-to-2.x branch February 6, 2024 01:46
eirsep added a commit to eirsep/security-analytics that referenced this pull request Mar 13, 2024
…ensearch-project#722) (opensearch-project#813)

* fix null query filter conversion from sigma to query string query

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix rule to query conversion tests for null filter

Signed-off-by: Surya Sashank Nistala <[email protected]>

* enhance test to verify non null doc doesnt match null query

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit a59a014)

Co-authored-by: Surya Sashank Nistala <[email protected]>
eirsep added a commit to eirsep/security-analytics that referenced this pull request Mar 13, 2024
…ensearch-project#722) (opensearch-project#813)

* fix null query filter conversion from sigma to query string query

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix rule to query conversion tests for null filter

Signed-off-by: Surya Sashank Nistala <[email protected]>

* enhance test to verify non null doc doesnt match null query

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit a59a014)

Co-authored-by: Surya Sashank Nistala <[email protected]>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants